Date: Mon, 2 Feb 2015 21:08:19 +0100 From: Juergen Lock <nox@jelal.kn-bremen.de> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Dirk Meyer <dinoex@FreeBSD.org>, svn-ports-head@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>, ports-committers@FreeBSD.org Subject: Re: svn commit: r378229 - head/sysutils/xen-tools Message-ID: <20150202200819.GA40212@enceladus10.kn-bremen.de> In-Reply-To: <20150202130123.GJ11558@ivaldir.etoilebsd.net> References: <201502010704.t1174age082281@svn.freebsd.org> <20150201073353.GA81373@FreeBSD.org> <20150201115859.GA92369@enceladus10.kn-bremen.de> <20150202130123.GJ11558@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 02, 2015 at 02:01:23PM +0100, Baptiste Daroussin wrote: > On Sun, Feb 01, 2015 at 12:58:59PM +0100, Juergen Lock wrote: > > On Sun, Feb 01, 2015 at 07:33:53AM +0000, Alexey Dokuchaev wrote: > > > On Sun, Feb 01, 2015 at 07:04:36AM +0000, Dirk Meyer wrote: > > > > New Revision: 378229 > > > > URL: https://svnweb.freebsd.org/changeset/ports/378229 > > > > QAT: https://qat.redports.org/buildarchive/r378229/ > > > > > > > > Log: > > > > - use full path in DEPENDS > > > > > > > > Modified: head/sysutils/xen-tools/Makefile > > > ============================================================================== > > > --- head/sysutils/xen-tools/Makefile Sat Jan 31 23:32:50 2015 (r378228) > > > +++ head/sysutils/xen-tools/Makefile Sun Feb 1 07:04:36 2015 (r378229) > > > @@ -13,9 +13,9 @@ COMMENT= Xen tools within FreeBSD domU > > > MASTER_SITES= http://bits.xensource.com/oss-xen/release/${PORTVERSION}/ > > > DISTFILES= xen-${PORTVERSION}.tar.gz > > > > > > -BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash \ > > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > +BUILD_DEPENDS= ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \ > > > + ${LOCALBASE}/lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > + ${LOCALBASE}/lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > > > > USES= gmake python:configure perl5 gettext-runtime:build gettext-tools:build pkgconfig > > > USE_PERL5= build > > > > > > > But why? What's the reason behind this change? > > > > > > ./danfe > > > > > I guess he meant... > > > > > -BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash \ > > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > +BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash > > > +LIB_DEPENDS= libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > + ibyajl.so:${PORTSDIR}/devel/yajl > > > > Cheers, > > Juergen > > > > Which would be wrong as well because xen-tools startically uses those > dependencies. > > So it does not depend on any.so it depends on a .a, meaning the right fix here > would be to use BUILD_DEPENDS= ${LOCALBASE}/libglib-2.0.a and not the .so > Ah I missed that it links static, yeah then better depend on the .a . Cheers, Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150202200819.GA40212>