From owner-svn-ports-head@FreeBSD.ORG Mon Feb 2 20:09:37 2015 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9E27447D; Mon, 2 Feb 2015 20:09:37 +0000 (UTC) Received: from smtp.kn-bremen.de (gruenbaer.kn-bremen.de [148.251.8.79]) by mx1.freebsd.org (Postfix) with ESMTP id 25F78BFA; Mon, 2 Feb 2015 20:09:36 +0000 (UTC) Received: by smtp.kn-bremen.de (Postfix, from userid 10) id 9AE613DE16D1; Mon, 2 Feb 2015 21:09:28 +0100 (CET) Received: from enceladus10.kn-bremen.de (noident@localhost [127.0.0.1]) by enceladus10.kn-bremen.de (8.14.5/8.14.5) with ESMTP id t12K8Krx040223; Mon, 2 Feb 2015 21:08:20 +0100 (CET) (envelope-from nox@enceladus10.kn-bremen.de) Received: (from nox@localhost) by enceladus10.kn-bremen.de (8.14.5/8.14.5/Submit) id t12K8JPq040222; Mon, 2 Feb 2015 21:08:19 +0100 (CET) (envelope-from nox) From: Juergen Lock Date: Mon, 2 Feb 2015 21:08:19 +0100 To: Baptiste Daroussin Subject: Re: svn commit: r378229 - head/sysutils/xen-tools Message-ID: <20150202200819.GA40212@enceladus10.kn-bremen.de> References: <201502010704.t1174age082281@svn.freebsd.org> <20150201073353.GA81373@FreeBSD.org> <20150201115859.GA92369@enceladus10.kn-bremen.de> <20150202130123.GJ11558@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150202130123.GJ11558@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Dirk Meyer , svn-ports-head@FreeBSD.org, Alexey Dokuchaev , svn-ports-all@FreeBSD.org, Juergen Lock , ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 20:09:37 -0000 On Mon, Feb 02, 2015 at 02:01:23PM +0100, Baptiste Daroussin wrote: > On Sun, Feb 01, 2015 at 12:58:59PM +0100, Juergen Lock wrote: > > On Sun, Feb 01, 2015 at 07:33:53AM +0000, Alexey Dokuchaev wrote: > > > On Sun, Feb 01, 2015 at 07:04:36AM +0000, Dirk Meyer wrote: > > > > New Revision: 378229 > > > > URL: https://svnweb.freebsd.org/changeset/ports/378229 > > > > QAT: https://qat.redports.org/buildarchive/r378229/ > > > > > > > > Log: > > > > - use full path in DEPENDS > > > > > > > > Modified: head/sysutils/xen-tools/Makefile > > > ============================================================================== > > > --- head/sysutils/xen-tools/Makefile Sat Jan 31 23:32:50 2015 (r378228) > > > +++ head/sysutils/xen-tools/Makefile Sun Feb 1 07:04:36 2015 (r378229) > > > @@ -13,9 +13,9 @@ COMMENT= Xen tools within FreeBSD domU > > > MASTER_SITES= http://bits.xensource.com/oss-xen/release/${PORTVERSION}/ > > > DISTFILES= xen-${PORTVERSION}.tar.gz > > > > > > -BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash \ > > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > +BUILD_DEPENDS= ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \ > > > + ${LOCALBASE}/lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > + ${LOCALBASE}/lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > > > > USES= gmake python:configure perl5 gettext-runtime:build gettext-tools:build pkgconfig > > > USE_PERL5= build > > > > > > > But why? What's the reason behind this change? > > > > > > ./danfe > > > > > I guess he meant... > > > > > -BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash \ > > > - lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > - lib/ibyajl.so:${PORTSDIR}/devel/yajl > > > +BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash > > > +LIB_DEPENDS= libglib-2.0.so:${PORTSDIR}/devel/glib20 \ > > > + ibyajl.so:${PORTSDIR}/devel/yajl > > > > Cheers, > > Juergen > > > > Which would be wrong as well because xen-tools startically uses those > dependencies. > > So it does not depend on any.so it depends on a .a, meaning the right fix here > would be to use BUILD_DEPENDS= ${LOCALBASE}/libglib-2.0.a and not the .so > Ah I missed that it links static, yeah then better depend on the .a . Cheers, Juergen