From owner-freebsd-current Fri Jul 19 5:43: 6 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 543C737B400 for ; Fri, 19 Jul 2002 05:43:03 -0700 (PDT) Received: from mx9.mail.ru (mx9.mail.ru [194.67.57.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD28F43E4A for ; Fri, 19 Jul 2002 05:43:01 -0700 (PDT) (envelope-from kan@mail.ru) Received: from [141.154.57.186] (helo=kan.dnsalias.net) by mx9.mail.ru with esmtp (Exim SMTP.9) id 17VX63-000PPM-00; Fri, 19 Jul 2002 16:43:00 +0400 Received: from kan.dnsalias.net (localhost [IPv6:::1]) by kan.dnsalias.net (8.12.5/8.12.5) with ESMTP id g6JCgqKS018793; Fri, 19 Jul 2002 08:42:52 -0400 (EDT) (envelope-from kan@kan.dnsalias.net) Received: (from kan@localhost) by kan.dnsalias.net (8.12.5/8.12.5/Submit) id g6JCgkJf018792; Fri, 19 Jul 2002 08:42:46 -0400 (EDT) Date: Fri, 19 Jul 2002 08:42:46 -0400 From: Alexander Kabaev To: Rob Hughes Cc: freebsd-current@FreeBSD.ORG Subject: Re: (Sort of) Solved Re: Current (DP1) on Toshiba 5005 Message-Id: <20020719084246.0c560593.kabaev@bellatlantic.net> In-Reply-To: <1027082010.1526.22.camel@kahuna-ws.robhughes.com> References: <1026823721.13803.59.camel@kahuna-ws.robhughes.com> <3D347C5D.7080900@attbi.com> <1027082010.1526.22.camel@kahuna-ws.robhughes.com> Reply-To: ak03@gte.com X-Mailer: Sylpheed version 0.7.8claws66 (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 19 Jul 2002 07:33:30 -0500 Rob Hughes wrote: > can't fetch resources for \\_SB_.LNKA - AE_BAD_DATA > can't fetch resources for \\_SB_.LNKB - AE_BAD_DATA > can't fetch resources for \\_SB_.LNKC - AE_BAD_DATA > can't fetch resources for \\_SB_.LNKF - AE_BAD_DATA > can't fetch resources for \\_SB_.LNKH - AE_BAD_DATA > can't fetch resources for \\_SB_.PCI0.FNC0.FSIR - AE_BAD_DATA ^^^^^^^ I had to patch ACPICA sources to make my laptoop to work. Apparently, folks at ACPI mailing list made exactly the same patch too. Returning AE_BAD_DATA for empty resource descriptors is wrong. Index: rsio.c =================================================================== RCS file: /home/ncvs/src/sys/contrib/dev/acpica/rsio.c,v retrieving revision 1.1.1.7 diff -u -r1.1.1.7 rsio.c --- rsio.c 9 Jul 2002 17:51:30 -0000 1.1.1.7 +++ rsio.c 14 Jul 2002 04:02:15 -0000 @@ -501,12 +501,14 @@ i++; } } +#if 0 if (i == 0) { /* Zero channels is invalid! */ return_ACPI_STATUS (AE_BAD_DATA); } +#endif OutputStruct->Data.Dma.NumberOfChannels = i; Index: rsirq.c =================================================================== RCS file: /home/ncvs/src/sys/contrib/dev/acpica/rsirq.c,v retrieving revision 1.1.1.9 diff -u -r1.1.1.9 rsirq.c --- rsirq.c 9 Jul 2002 17:51:30 -0000 1.1.1.9 +++ rsirq.c 14 Jul 2002 03:30:02 -0000 @@ -190,12 +190,14 @@ } } +#if 0 if (i == 0) { /* Zero interrupts is invalid! */ return_ACPI_STATUS (AE_BAD_DATA); } +#endif OutputStruct->Data.Irq.NumberOfInterrupts = i; /* -- Alexander Kabaev To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message