From owner-p4-projects@FreeBSD.ORG Sun May 17 13:56:25 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 15F8F1065674; Sun, 17 May 2009 13:56:25 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 070841065670; Sun, 17 May 2009 13:56:23 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 52B3B8FC0C; Sun, 17 May 2009 13:56:21 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by bwz9 with SMTP id 9so2733795bwz.43 for ; Sun, 17 May 2009 06:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=vAUrdSR5cR0pUqOcDEPQcnL8i7cl/okX9Qz7zwpDytM=; b=iFefiBiUVVNVx4v9XM7qJKknM7kydrhtTvuoZpVToYCEDSom+pzUHNjvDmYqaWOiH+ KOYBxyg9/VeAN7kXIg/G8BMcQA8o1Z1rmumzStV7DhWumh+AiWiRF1q9u2IF/VMT+Tz5 45ufvNM6FnM71gWtpOtWIH6PXvIMS3rUc/11I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=sU0nXmhASn03hDaPt8oUr01498exI1y3+FGKsCdofnXV2md7H3lXmCZWYOIKDkkZxo NI0QMQ2DJECWIM7iAK8cUZPPpEvAej4QBlmQlIlpTiyoTyqh59zH0vZRTQ4iHCTbJtpV 36kxScvYQHMfJaOAKhxOPRKIGd/1+5vezgF6w= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.223.103.207 with SMTP id l15mr3766540fao.2.1242567134535; Sun, 17 May 2009 06:32:14 -0700 (PDT) In-Reply-To: <200905171226.n4HCQXS9011874@repoman.freebsd.org> References: <200905171226.n4HCQXS9011874@repoman.freebsd.org> Date: Sun, 17 May 2009 15:32:14 +0200 X-Google-Sender-Auth: 7885ae84009b52e5 Message-ID: <3bbf2fe10905170632g7ad74f3dk3cdb3ad5576da394@mail.gmail.com> From: Attilio Rao To: Zhao Shuai Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews , John Baldwin Subject: Re: PERFORCE change 162206 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2009 13:56:25 -0000 2009/5/17 Zhao Shuai : > http://perforce.freebsd.org/chv.cgi?CH=3D162206 > > Change 162206 by zhaoshuai@zhaoshuai on 2009/05/17 12:25:57 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0some changes in the pipe code > =C2=A0 =C2=A0 =C2=A0 =C2=A0first version of fifo, incomplete > > Affected files ... > > .. //depot/projects/soc2009/fifo/sys/fs/fifofs/fifo.c#2 edit > .. //depot/projects/soc2009/fifo/sys/kern/sys_pipe.c#2 edit > .. //depot/projects/soc2009/fifo/sys/sys/pipe.h#2 edit > I'm not sure how do you and John want to organize the work, but when I was thinking about it my main idea was firstly to refactorize the pipe code, identifying common parts that can be shared and put under subr_something.c (for example) to be sucked in by both pipes and FIFOs main code. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein