From owner-cvs-src@FreeBSD.ORG Wed Aug 25 22:35:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3955616A4CE; Wed, 25 Aug 2004 22:35:26 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3D3243D2D; Wed, 25 Aug 2004 22:35:25 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i7PMX8Ne045958; Wed, 25 Aug 2004 18:33:09 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i7PMX8OV045955; Wed, 25 Aug 2004 18:33:08 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 25 Aug 2004 18:33:08 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20040825221542.GB26612@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 22:35:26 -0000 On Wed, 25 Aug 2004, Alfred Perlstein wrote: > > Don't hold the UNIX domain socket subsystem lock over the body of the > > UNIX domain socket garbage collection implementation, as that risks > > holding the mutex over potentially sleeping operations (as well as > > introducing some nasty lock order issues, etc). unp_gc() will hold > > the lock long enough to do necessary deferal checks and set that it's > > running, but then release it until it needs to reset the gc state. > > Which alfred? :) The one true Alfred, of course. But mind you, this was right after I first committed the UNIX domain socket locking, which was several months ago... :-). Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research