From owner-svn-src-all@freebsd.org Tue Jan 22 18:13:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 597B814AA6D4; Tue, 22 Jan 2019 18:13:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8A8A97219; Tue, 22 Jan 2019 18:13:03 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd29.google.com with SMTP id k2so19876420iog.7; Tue, 22 Jan 2019 10:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DW0eb+zv2NZxrR/ceid+v2jLLPo6ps51j2M/byTTwBw=; b=sr++J1IC0X7RhuS4eugg3hadqNFOhJgmIBvz7xec2a5zpMeadNWJHQdcsdqRPfRxYr qnq4J2el7FH5oDp+W9VzRxGqQ3Z8JAOBzz0/9aT+2yFfLXUav7L7rTzbfFYB9KB6EY2a NHaBklkH29Dq26ZZnS2K00RLoSBBX5ezB+uYjxm+IPBBuDOqYfjPyMb9RjCZh8KD9eWS p6pPf1/0smiPuXr1t0eOGl8gbBQDgUH6Qgwjk4WqZGs3xpOC24C9lnk61zmz2pOuUfgx tHjQQWtdEX8NBBGw1kwcW7hvqb3BkI05m4viGjmnZFeVQUH2INzP5oWRjwzL43sfB6KT Ek6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=DW0eb+zv2NZxrR/ceid+v2jLLPo6ps51j2M/byTTwBw=; b=cb/VfyfuiiDH53qruEpAqb4hmqhSBj8gs0Ir90NG4Xxf1Bx401Y7QVUWoW+ng4vMdl fiC0OqSVLaPRfPAUYKTcQYnFKo19Cv4c9vuOeNZwwdYIT2D6r+eFinSewCQgGiqCfprx ahSBonpnQBnJp6nO4ZDXEAqwqnUvKo+S2IUnKTtEcw/+hwgo+4Hl6/5ob9+9XKPj2q8r ApNx8T0hu9oCPAS4j22HmuuoFr1DQlzIIzxmuFe/B2fbu9q68FSnREff+9gualJlKfBM 3A2flH6oEeMdQzDq3qEytooUJSVrLC+wXTnm/c4IEQS2FqNFHloBGUQFyRLeRY4dZ5vY JnZQ== X-Gm-Message-State: AJcUukfYOktOZCHQO848h8eAYHJl58I/vnu2fE/bDWKty//XGjqMCgey 6NFOBsvWZQCxsSsJww+lAAeFGcwoEdc= X-Google-Smtp-Source: ALg8bN7/2mgAfEkApR6PmMK18F6tkn78GxmXF0edaI8xB20u6qq4oI9rs/SnQdBlWdTvCEvwxf9elQ== X-Received: by 2002:a6b:f017:: with SMTP id w23mr18090377ioc.12.1548180782782; Tue, 22 Jan 2019 10:13:02 -0800 (PST) Received: from raichu (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id e21sm8147064itc.6.2019.01.22.10.13.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 10:13:02 -0800 (PST) Sender: Mark Johnston Date: Tue, 22 Jan 2019 13:12:57 -0500 From: Mark Johnston To: Ian Lepore Cc: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343305 - head/sys/net Message-ID: <20190122181257.GA81189@raichu> References: <201901221739.x0MHdQps047360@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: D8A8A97219 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.939,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 18:13:04 -0000 On Tue, Jan 22, 2019 at 10:45:16AM -0700, Ian Lepore wrote: > On Tue, 2019-01-22 at 17:39 +0000, Brooks Davis wrote: > > Author: brooks > > Date: Tue Jan 22 17:39:26 2019 > > New Revision: 343305 > > URL: https://svnweb.freebsd.org/changeset/base/343305 > > > > Log: > > Rework CASE_IOC_IFGROUPREQ() to require a case before the macro. > > > > This is more compatible with formatting tools and looks more > > normal. > > > > Reported by: jhb (on a different review) > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D18442 > > > > Modified: > > head/sys/net/if.c > > > > Modified: head/sys/net/if.c > > ===================================================================== > > ========= > > --- head/sys/net/if.c Tue Jan 22 17:34:53 2019 (r343304) > > +++ head/sys/net/if.c Tue Jan 22 17:39:26 2019 (r343305) > > @@ -168,14 +168,14 @@ struct ifmediareq32 { > > #define SIOCGIFXMEDIA32 _IOC_NEWTYPE(SIOCGIFXMEDIA, struct > > ifmediareq32) > > > > #define _CASE_IOC_IFGROUPREQ_32(cmd) > > \ > > - case _IOC_NEWTYPE((cmd), struct ifgroupreq32): > > + _IOC_NEWTYPE((cmd), struct ifgroupreq32): case > > That 'case' at the end of the line doesn't look right. With the change, CASE_IOC_IFGROUPREQ(cmd) yields case 32: case : which seems to be the intent.