From owner-freebsd-testing@FreeBSD.ORG Tue Jan 21 22:45:57 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45DB5EC6 for ; Tue, 21 Jan 2014 22:45:57 +0000 (UTC) Received: from mail-wi0-x233.google.com (mail-wi0-x233.google.com [IPv6:2a00:1450:400c:c05::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D64651175 for ; Tue, 21 Jan 2014 22:45:56 +0000 (UTC) Received: by mail-wi0-f179.google.com with SMTP id hr1so4975282wib.0 for ; Tue, 21 Jan 2014 14:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=URW61zoK1s72f6DfErMLd1aBU8elxQ1ceoJC2gZS7o4=; b=FWZT3pcyUX/pQHaMmIUhnfnWHTF8tttbD9qWil9o0WsNLy5wC9gVjbzCN7kpxAyqkI FcP5EvE46sN7dzs5Lg2aghzLa7FIHCLfLJ9JCxX+HmdxRfnyW/iR5jOLC5Igci/WyNKC EArUFx2kWQ2fmSr03PLgQHf+nhSueGb82YOq57W18vrpmZbTSrieRGodFwXeWYOnha0f k9bNhh5bqb1qWm6oG0T7rRmid9bf4Pg67M3UK6viidjY0sBHsRStGKX1HB5Qy+SzOXpP UTkbtNHMk79QbbVpTSullUffNI5MZ4jEGFLetonQYV0odSqSNwWPFHwfpozh+BGOFtAV ur9Q== MIME-Version: 1.0 X-Received: by 10.194.63.228 with SMTP id j4mr21743664wjs.34.1390344355160; Tue, 21 Jan 2014 14:45:55 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.22.35 with HTTP; Tue, 21 Jan 2014 14:45:55 -0800 (PST) Date: Tue, 21 Jan 2014 15:45:55 -0700 X-Google-Sender-Auth: syPep2oTHs3NgXG2HDsTNKzVasA Message-ID: Subject: PATCH: add ATF tests in sys From: Alan Somers To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 22:45:57 -0000 I rewrote the unix seqpacket tests in ATF. The hard part is adding them to the build. The linked patch adds them in the directory sys/kern/tests and builds them as part of buildworld, not buildkernel. They get installed to /usr/tests/sys/kern, but the intermediate objects are stored in /usr/obj/sys/kern/tests. That means that you can't have different tests associated with different kernel configs. I think that this is desirable, because you wouldn't be able to install tests for different kernel configs anyway, given our chosen layout of /usr/tests. Please comment on the parts of this patch that deal with Makefiles. Is this the appropriate way to add sys tests to the build? Shouldn't I be building them in buildkernel instead of buildworld? I couldn't find a good way to do that. https://gist.github.com/asomers/5f98656d574e68314029