Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Oct 2017 12:05:20 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Ashish SHUKLA <ashish@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r451116 - in head/lang/sagittarius-scheme: . files
Message-ID:  <k20c-r1gf-wny@FreeBSD.org>
In-Reply-To: <201710030826.v938Q6dt022417@repo.freebsd.org> (Ashish SHUKLA's message of "Tue, 3 Oct 2017 08:26:06 %2B0000 (UTC)")
References:  <201710030826.v938Q6dt022417@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Ashish SHUKLA <ashish@FreeBSD.org> writes:

> Author: ashish
> Date: Tue Oct  3 08:26:06 2017
> New Revision: 451116
> URL: https://svnweb.freebsd.org/changeset/ports/451116
>
> Log:
>   - Update to 0.8.7
>   - Add SIMD option (off by default) to control compilation with SIMD
>     flags
>   - Add program to generate cpuinfo required for SIMD support detection
[...]
> ++   ELSEIF(CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
> ++     EXEC_PROGRAM(%%CPUID%% OUTPUT_VARIABLE CPUINFO)
> ++
> ++     STRING(REGEX REPLACE "^.*,(SSE2).*$" "\\1" SSE_THERE ${CPUINFO})
> ++     STRING(COMPARE EQUAL "SSE2" "${SSE_THERE}" SSE2_TRUE)
> ++     IF (SSE2_TRUE)
> ++       set(SSE2_FOUND true CACHE BOOL "SSE2 available on host")
> ++     ELSE (SSE2_TRUE)
> ++       set(SSE2_FOUND false CACHE BOOL "SSE2 available on host")
> ++     ENDIF (SSE2_TRUE)
[...]
>     IF (USE_SSE)
>      IF (SSE2_FOUND)
> 	SET(CMAKE_C_FLAGS "-msse2 ${CMAKE_C_FLAGS}")
> 	SET(CMAKE_CXX_FLAGS "-msse2 ${CMAKE_CXX_FLAGS}")
>       ENDIF()

Given the lack of __SSE*__ guards in the source -m* flags look like a
cargo cult optimization or a verbose way to say CFLAGS += -march=native.
For one, users with CPUTYPE set via make.conf already have -march= which
enables -m* flags supported by the specific CPU.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?k20c-r1gf-wny>