From owner-freebsd-acpi@FreeBSD.ORG Tue Jul 10 16:30:58 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56DC71065670; Tue, 10 Jul 2012 16:30:58 +0000 (UTC) (envelope-from vmagerya@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id CCB838FC14; Tue, 10 Jul 2012 16:30:57 +0000 (UTC) Received: by ggnm2 with SMTP id m2so213128ggn.13 for ; Tue, 10 Jul 2012 09:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sc9v48x62yF38zbo98e4CkBZIX6txSf7onu8jiQbPdA=; b=Iy7sg7nI7a5T3FVixWHWw9IaA4TV8RNsqu68veBauR69eIBJCYGDNVgdyWnema6qia Hl6N/xnbXYoxgutJ34ugTPxbKhnZuhZLlKbmEoY+6aLk+G5cZ9Bmy3vOvDDBPN2ci2YC GTDZvO6jB2ql0A2JSZu6aNBGXRpBJBnLhAnZqJxw7Rxnueox89w25RmQc477BLNaVhUm caUQgLPDHSfj4Qew1Bygl8z3KQ4vEm2W9ZZDc43yTe8cf71ksLwE1sVnR0h3O1EnM/xm P+mo7DIEIrYX8bx4GqrLqNyGhh/Mbxwu+HYTTRIFtr9oVSgbRwGTrGzTc8hXEf9g4xN3 AUQA== MIME-Version: 1.0 Received: by 10.66.89.170 with SMTP id bp10mr74536229pab.12.1341937856861; Tue, 10 Jul 2012 09:30:56 -0700 (PDT) Received: by 10.142.239.12 with HTTP; Tue, 10 Jul 2012 09:30:56 -0700 (PDT) In-Reply-To: <4FF95F79.30309@FreeBSD.org> References: <4FF95F79.30309@FreeBSD.org> Date: Tue, 10 Jul 2012 19:30:56 +0300 Message-ID: From: Vitaly Magerya To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-acpi@freebsd.org" , Giovanni Trematerra Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 16:30:58 -0000 Andriy Gapon wrote: > I would like to propose the following change for review and testing: > http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff I just tested this on a laptop that jumps between reporting only C1, C1 and C2, and C1 through C3; in all cases your patch does the right thing, so this removes the need for kludges I had to do earlier; thank you, Andriy. Will you also change how /etc/rc.d/power_profile selects lowest_value? It currently uses the maximum from dev.cpu.0.cx_supported, but with your patch it'll be the right thing to simply use Cmax.