From owner-svn-src-all@freebsd.org Wed Nov 4 15:32:04 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3675E45FCFC; Wed, 4 Nov 2020 15:32:04 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CR9cg6RFXz3dpc; Wed, 4 Nov 2020 15:32:03 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f52.google.com with SMTP id p7so22625549ioo.6; Wed, 04 Nov 2020 07:32:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Kec1rwm/YIGVf6xaanRZyP4Hr/iu2yGoYQBQuS1jUP8=; b=H0oV9G21U4MGbXqqSGMXnAc1bA7Q75Pkfsyr3owNxNAWUl7do/uOu9EVC8zzDg6G+U BCPGWpwLyVg+H9RsVcqBQZ5JdVtX/DBZNySX+MnFC2iG3XOh+VDXp2yzEqfgJHP1uNEd T7cBJ+8w9MCMhpRfnUSwPh/XEh2A/FogLVaU8+iVPQYuCZKLZtEhN4VP0F7kAer77kek dGUSOXWqsI0nnhMkIaO1y67viJyWwHGnwTxMsR1XfxFTsa358FvR4GfnrAe/cjXe2t1Z x96Ytgp4pneRkR6Rz9H9WemdCYqF5VOVkhnTsjeLFzQVRI93fGZKq9o07hfXprlD1xoW vWbQ== X-Gm-Message-State: AOAM530Pn9N3CCy0HJDneCe3t8E/AVIBjZhz/CCAHPXSuz6suLSqbYpm s+lyqiSTmx/VR53IsyJmaJbrvFh6a+SPIPcST+xxYDd6 X-Google-Smtp-Source: ABdhPJy3nR/dua5mFWC/gUXHOM/6XRI4jw4hz4QHbz3AG5VZ1WdHbQKSgSbuIhew6hxwtg1IkYkWGRmtXkLoftP05Wo= X-Received: by 2002:a05:6638:1181:: with SMTP id f1mr10663050jas.106.1604503922501; Wed, 04 Nov 2020 07:32:02 -0800 (PST) MIME-Version: 1.0 References: <202011041038.0A4AcPNn082013@repo.freebsd.org> <20201104104515.GA83813@lion.0xfce3.net> In-Reply-To: From: Ed Maste Date: Wed, 4 Nov 2020 10:31:50 -0500 Message-ID: Subject: Re: svn commit: r367321 - head/sys/amd64/linux To: Kristof Provost Cc: Gordon Bergling , Mateusz Piotrowski <0mp@freebsd.org>, src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4CR9cg6RFXz3dpc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 15:32:04 -0000 On Wed, 4 Nov 2020 at 07:10, Kristof Provost wrote: > > > And why you just abandoned the differential [1]? > > > Probably because it timed out. The review had been pending since August. > Arguably the differential link should have been included as well, but > it=E2=80=99s hardly important in this case. I don=E2=80=99t think we have= explicit > policies about this. We probably should. Yes, it's still worth including the phab URL so that it closes automatically and so that others can see how long it was open for. I take no issue with the change itself.