Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Dec 2021 04:18:07 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        John Hixson <jhixson@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: cc1054f95110 - main - sysutils/oc: Update to use personal fork of oc
Message-ID:  <Yblsf%2BH9os5i93XK@FreeBSD.org>
In-Reply-To: <YblprK1LY/xHAkNd@nerd.divinix.org>
References:  <202112150129.1BF1TiVb091373@gitrepo.freebsd.org> <YblQuvbCr49hq/M0@FreeBSD.org> <YblprK1LY/xHAkNd@nerd.divinix.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 14, 2021 at 08:06:04PM -0800, John Hixson wrote:
> On Wed, Dec 15, 2021 at 02:19:38AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Dec 15, 2021 at 01:29:44AM +0000, John Hixson wrote:
> > > commit cc1054f951104c0404446bc0787de6e3399c4a66
> > > 
> > >     sysutils/oc: Update to use personal fork of oc
> > 
> > Why?  Please don't just translate the diff into English, you have to
> > explain the changes, esp. dubious ones like this.
> 
> My apologies. I will write better commit messages. Fetching keeps
> breaking because the downloadable tarball keeps changing. I beleive it's
> from forced pushes and commits changing. I can track it with my own fork
> so that it doesn't keep changing and breaking. Is this practice frowned
> upon?

No, given the explanation it's okay.  Yes, please write elaborate commit
logs, what might be obvious to you, as an author, is not necessarily so
for a random reader.  Changing upsream from official to something else
would certainly raise a few eyebrows.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yblsf%2BH9os5i93XK>