From owner-svn-src-head@freebsd.org  Wed Apr 19 12:26:22 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D1C0D45FB2;
 Wed, 19 Apr 2017 12:26:22 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 09A711BE7;
 Wed, 19 Apr 2017 12:26:22 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id EE71F1FE022;
 Wed, 19 Apr 2017 14:26:18 +0200 (CEST)
Subject: Re: svn commit: r316811 - head/sys/contrib/ipfilter/netinet
To: Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201704140513.v3E5Dp7v039091@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <45d50d78-239a-8d9a-286f-310513c3b8a4@selasky.org>
Date: Wed, 19 Apr 2017 14:24:29 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <201704140513.v3E5Dp7v039091@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Apr 2017 12:26:22 -0000

On 04/14/17 07:13, Cy Schubert wrote:
> Author: cy
> Date: Fri Apr 14 05:13:50 2017
> New Revision: 316811
> URL: https://svnweb.freebsd.org/changeset/base/316811
>
> Log:
>   Add missing free()'s after calls to randomize().
>
>   PR:		NetBSD PR/50559
>   Obtained from:	Netbsd radix_ipf.c r1.6
>   MFC after:	1 week
>
> Modified:
>   head/sys/contrib/ipfilter/netinet/radix_ipf.c
>
> Modified: head/sys/contrib/ipfilter/netinet/radix_ipf.c
> ==============================================================================
> --- head/sys/contrib/ipfilter/netinet/radix_ipf.c	Fri Apr 14 05:12:01 2017	(r316810)
> +++ head/sys/contrib/ipfilter/netinet/radix_ipf.c	Fri Apr 14 05:13:50 2017	(r316811)
> @@ -38,7 +38,7 @@ static void buildnodes __P((addrfamily_t
>  static ipf_rdx_node_t *ipf_rx_find_addr __P((ipf_rdx_node_t *, u_32_t *));
>  static ipf_rdx_node_t *ipf_rx_lookup __P((ipf_rdx_head_t *, addrfamily_t *,
>  					  addrfamily_t *));
> -static ipf_rdx_node_t *ipf_rx_match __P((ipf_rdx_head_t *, addrfamily_t *));
> +/*	$NetBSD: radix_ipf.c,v 1.6 2015/12/15 12:30:34 christos Exp $	*/
>
>  /*
>   * Foreword.
> @@ -1509,6 +1509,8 @@ random_add(rnh)
>  		add_addr(rnh, i, order[i]);
>  		checktree(rnh);
>  	}
> +
> +	free(order);
>  }
>
>
> @@ -1526,5 +1528,7 @@ random_delete(rnh)
>  		delete_addr(rnh, i);
>  		checktree(rnh);
>  	}
> +
> +	free(order);
>  }
>  #endif /* RDX_DEBUG */
>
>

I'm seeing this compilation warning:

freebsd/sys/contrib/ipfilter/netinet/radix_ipf.c:184: warning: function 
declaration isn't a prototype [-Wstrict-prototypes]
*** [radix_ipf.o] Error code 1


--HPS