From owner-freebsd-arch@FreeBSD.ORG Thu Dec 25 05:53:56 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0D7DCB38; Thu, 25 Dec 2014 05:53:56 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id E9EE62690; Thu, 25 Dec 2014 05:53:55 +0000 (UTC) Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id B093C341F85A; Wed, 24 Dec 2014 21:53:54 -0800 (PST) Message-ID: <549BA675.9070107@freebsd.org> Date: Wed, 24 Dec 2014 21:53:57 -0800 From: Alfred Perlstein Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Simon J. Gerraty" Subject: Libxo bugs and fixes. References: <201408141640.s7EGe422096656@idle.juniper.net> <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net> <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net> <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net> In-Reply-To: <20140816045254.5F47E580A2@chaos.jnpr.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcel Moolenaar , Phil Shafer , John-Mark Gurney , arch@freebsd.org, Poul-Henning Kamp , freebsd-arch , Konstantin Belousov X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 05:53:56 -0000 On 8/15/14 9:52 PM, Simon J. Gerraty wrote: > On Fri, 15 Aug 2014 17:35:23 -0700, Alfred Perlstein writes: >> should get towards converting more utils to using it. However if we are >> going to perpetually add frameworky things, but not convert over >> userland tools to the actual framework, then that is a potential problem >> worth calling out. > Indeed. Again that's why I prefer to see this (the library at least) > done by someone who's been doing this sort of thing successfuly for > ages. OK, So I've been hacking on this over the last day or so and have the following deltas up for review: 1) We need libxo to support explicit fflush: https://reviews.freebsd.org/D1379 2) We need libxo to support time series data. I don't have a patch for that, but I would like to ask for ideas on this. This would be extremely helpful for instance "netstat 1". would like to get a very accurate timestamp with each row. Suggestions on how to do this correctly AND *consistently* via libxo would make sense. 3) I have netstat mostly converted over, however not all the json is valid, I will be doing another pass ASAP on this. https://reviews.freebsd.org/D1380 4) Can I as politely as I know how, ask that Juniper keep the patches against the userland utils up to date either in a project branch in SVN, or simply in a fork of the github repo? This would make life so much easer to deal with. As an example you can look at my github repo where I have the netstat code forward ported on a branch here: https://github.com/splbio/freebsd/tree/ap_libxo_netstat and here: https://github.com/splbio/freebsd/compare/ap_libxo_netstat?expand=1 -Alfred