From owner-freebsd-bugs@FreeBSD.ORG  Sun Aug 22 08:20:05 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1D37610656A5
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 22 Aug 2010 08:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E70F18FC1F
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 22 Aug 2010 08:20:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7M8K4ON069090
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 22 Aug 2010 08:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7M8K4Tu069088;
	Sun, 22 Aug 2010 08:20:04 GMT (envelope-from gnats)
Date: Sun, 22 Aug 2010 08:20:04 GMT
Message-Id: <201008220820.o7M8K4Tu069088@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Garrett Cooper <yaneurabeya@gmail.com>
Cc: 
Subject: Re: kern/145385: [cpu] Logical processor cannot be disabled for
	some SMT-enabled Intel procs
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yaneurabeya@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Aug 2010 08:20:05 -0000

The following reply was made to PR kern/145385; it has been noted by GNATS.

From: Garrett Cooper <yaneurabeya@gmail.com>
To: bug-followup@FreeBSD.org,
 gcooper@FreeBSD.org
Cc: jhb@FreeBSD.org
Subject: Re: kern/145385: [cpu] Logical processor cannot be disabled for some SMT-enabled Intel procs
Date: Sun, 22 Aug 2010 01:17:37 -0700

 --Apple-Mail-10--784820364
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 	The following trivial patch fixes the issue on my W3520 =
 processor; AFAICS it's what should be done after reading several of the =
 specs because the logical count that's tracked with ebx is exactly what =
 is needed for logical_cpus (it's an absolute quantity). I need to verify =
 it with a multi-cpu topology at work (the two r710s I was testing with =
 E-series Xeons on aren't available remotely right now).
 Thanks!
 -Garrett
 
 
 --Apple-Mail-10--784820364
 Content-Disposition: attachment;
 	filename=kern-145385.diff
 Content-Type: application/octet-stream;
 	name="kern-145385.diff"
 Content-Transfer-Encoding: 7bit
 
 Index: sys/amd64/amd64/mp_machdep.c
 ===================================================================
 --- sys/amd64/amd64/mp_machdep.c	(revision 211309)
 +++ sys/amd64/amd64/mp_machdep.c	(working copy)
 @@ -203,7 +203,7 @@
  				cnt++;
  		}
  		if (type == CPUID_TYPE_SMT)
 -			cpu_logical = cnt;
 +			cpu_logical = logical_cpus = cnt;
  		else if (type == CPUID_TYPE_CORE)
  			cpu_cores = cnt;
  	}
 
 --Apple-Mail-10--784820364--