From nobody Sat Apr 29 08:46:56 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q7jl55nzqz48hb3; Sat, 29 Apr 2023 08:46:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q7jl44PG1z3PmJ; Sat, 29 Apr 2023 08:46:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682758016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kOUI+2LMcMzRiTEqZJT2sTr+x/z/4Ed/GTVHtP2jfnQ=; b=f5dnfVDHmg6puMzFi/DChqkJqeNMC1Q1LIxoXBmlhyyDMC0eXgGn9xU7dWeqipaULn72/f b5sembs8GrcYCOTsb1XxovA8bBZ13i+cWulJllWO5LjvavV9JyPBchNpSYl66aWUPLmRbg hBwl1kIaMyZkh6mO4Wzg4XImJBToEHg1mUEcpfDG1qOFreMCv55uRCklFRJ/0b5jhOjztR HBHsZnEcsJQuuIlWeMYOtuLN+MuVQkxMgH+T6yER0PbiHXru93g0O2Q9n8TRW6YC1TU0nJ RK1vEzXwErgI2m16iolB/QLY00wvFczAAbUR9PuQv0GyUkEpCtXxjnglX89WKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682758016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kOUI+2LMcMzRiTEqZJT2sTr+x/z/4Ed/GTVHtP2jfnQ=; b=Vhl/6Y492o03e4fbq0dG+Js4T+hGiNWjVoSfdAjfKyNzYlp/2EASFjMV10WyNMQWxBV3kI hgIvNMgwW7/5+vglKQmMP0M0g9ywhNuAY3p5opH6DXoEKBO38RhJo020hUR4U0Vekpubrc AbIWE5IQHIS99UTdSaTWPKUxpaFO8txc3BM8zrxJXXb/7x47Kbk8kLQqF0rGapctjIHpc4 p2NRTurQIlPT7r2pnz4Eur3qEuhGsaAMpRnWV6rVQWv/W5AqPjuzK3G0bXkH8g0hZ+uWZB HBlDH6RwLtYtW/v2F3r0K76sflQ+aPvFd9bpECOC6pQyRDj0ZpBAuFiJt3kmhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682758016; a=rsa-sha256; cv=none; b=n7OotJ7GovrWmpMetV3VxCJ+ycY5yjYd7jlzSiY2dHaD99JXoA7FHHyAp2nAgZZXIyoS+A nfKtobOJLDdczdyp1OvifA/VBRIXFelz0Wu+R7AnsmmAefhqUvW8UJ0P5I1euQCwkUpZvC EnPE/tF8hLPXqbmkejgd+XYGGPNqR6Y0+lNeshIxUg5D0i2xHo5eECmzq1mNO7+YXIvJg2 snuUWEqF2MoBp/qxj2CnaZ2AenrGWZ9Ll0NDwYMrO2XJ6y7GP1vYvjZKo7A+Rf63QYF+v6 W+ik0zk2Ti7p1WW7zGXm2DfQ5qQ11gHA0PQeTRgUSGeWX0NatZ2/TQXVnmzdOQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q7jl43HNXzZsH; Sat, 29 Apr 2023 08:46:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33T8kusD079406; Sat, 29 Apr 2023 08:46:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33T8kua6079405; Sat, 29 Apr 2023 08:46:56 GMT (envelope-from git) Date: Sat, 29 Apr 2023 08:46:56 GMT Message-Id: <202304290846.33T8kua6079405@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 6c7525282e52 - main - java/openjdk8: fix build with clang 16 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6c7525282e522052f7416bf30223c7c56f3a5b63 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=6c7525282e522052f7416bf30223c7c56f3a5b63 commit 6c7525282e522052f7416bf30223c7c56f3a5b63 Author: Dimitry Andric AuthorDate: 2023-04-26 12:38:28 +0000 Commit: Dimitry Andric CommitDate: 2023-04-29 08:45:36 +0000 java/openjdk8: fix build with clang 16 Since clang 16 (and gcc 11) the default C++ standard is now gnu++17. Because java/openjdk8's build infrastructure does not explicitly set its C++ standard, this leads to several errors: /wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/arena.cpp:82:3: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] register Chunk *k = _first; ^~~~~~~~~ /wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/arena.cpp:96:3: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] register Chunk *k = _chunk; // Get filled-up chunk address ^~~~~~~~~ 2 errors generated. /wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/adlparse.cpp:4567:3: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] register char c; ^~~~~~~~~ /wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/adlparse.cpp:4765:3: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] register char c; ^~~~~~~~~ For newer versions of OpenJDK this has been fixed by removing the 'register' keyword, but upstream has not yet backported it to OpenJDK 8. To work around the errors, define the register keyword away using a command line flag. PR: 271080 Approved by: glewis (maintainer) MFH: 2023Q2 --- java/openjdk8/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/java/openjdk8/Makefile b/java/openjdk8/Makefile index 688035a60d89..6196947d8f30 100644 --- a/java/openjdk8/Makefile +++ b/java/openjdk8/Makefile @@ -1,5 +1,6 @@ PORTNAME= openjdk PORTVERSION= ${JDK_MAJOR_VERSION}.${JDK_UPDATE_VERSION}.${JDK_BUILD_NUMBER}.${BSD_JDK_VERSION} +PORTREVISION= 1 CATEGORIES= java devel MASTER_SITES= LOCAL/jkim:jtreg PKGNAMESUFFIX?= ${JDK_MAJOR_VERSION} @@ -213,6 +214,13 @@ BUILD_DEPENDS+= clang${LLVM_VER}:devel/llvm${LLVM_VER} CC= ${LOCALBASE}/bin/clang${LLVM_VER} CXX= ${LOCALBASE}/bin/clang++${LLVM_VER} .endif +.if ${COMPILER_VERSION} >= 160 +# clang 16 defaults to C++17, which no longer allows the 'register' keyword. +# There is an upstream commit that removes all the individual 'register' +# keywords, but it has not yet been backported to OpenJDK 8. +# NOTE: passing this option via --with-extra-cflags does not work. +CFLAGS+= -Dregister= +.endif .endif # GCC is broken with PCH: https://lists.freebsd.org/pipermail/svn-src-all/2015-March/101722.html