From owner-freebsd-bugs@FreeBSD.ORG  Mon Apr 24 11:50:21 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2786B16A405
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 24 Apr 2006 11:50:21 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E82F143D4C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 24 Apr 2006 11:50:20 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3OBoIo3041983
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 24 Apr 2006 11:50:18 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3OBoIQp041982;
	Mon, 24 Apr 2006 11:50:18 GMT (envelope-from gnats)
Date: Mon, 24 Apr 2006 11:50:18 GMT
Message-Id: <200604241150.k3OBoIQp041982@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Alex Kozlov <spam@rm-rf.kiev.ua>
Cc: 
Subject: Re: bin/96248: vipw fail on RO /etc
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alex Kozlov <spam@rm-rf.kiev.ua>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2006 11:50:21 -0000

The following reply was made to PR bin/96248; it has been noted by GNATS.

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Maxim Konovalov <maxim@macomnet.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/96248: vipw fail on RO /etc
Date: Mon, 24 Apr 2006 14:39:53 +0300

 On Mon, Apr 24, 2006 at 12:24:29PM +0400, Maxim Konovalov wrote:
 > On Mon, 24 Apr 2006, 11:07+0300, Alex Kozlov wrote:
 > 
 > > On Mon, Apr 24, 2006 at 11:17:08AM +0400, Maxim Konovalov wrote:
 > > > [...]
 > > > > if rootfs mount as read-only, vipw fall to execute witch vipw:
 > > > > pw_tmp(): Read-only file system error.
 > > > > >How-To-Repeat:
 > > > > #mount |grep -w /
 > > > > /dev/da0s1 on / (ufs, local, read-only)
 > > > >
 > > > > #vipw
 > > > > vipw: pw_tmp(): Read-only file system
 > > > > >Fix:
 > > > > Change temporary file patch in pw_tmp() from
 > > > >
 > > > > if (snprintf(tempname, sizeof(tempname), "%.*spw.XXXXXX",
 > > > >         (int)(p - masterpasswd), masterpasswd) >= (int)sizeof(tempname)) {
 > > > >
 > > > > to more appropriate?
 > > >
 > > > And what is more appropriate?
 > > Quite good solution may be to add fallback mechanism in case if masterpasswd
 > > directory not writable.
 > >
 > > There are any (security?) reasons, which to prevent the storing of
 > > pw_tmp file in /tmp ?
 > 
 >Perhaps they are, I don't know.  I don't think changing passwd temp
 >files location is a good idea.
 In case of /tmp? Perhaps. Just to be on safe side, choose directory
 writable only for root. Say, /var/run.
 Sudo already use /var/run/sudo.
 
 Any security advantages /etc in comparison with /var/run ?
 
 Both have equal permissions.
 If crash happens, /var/run/pw.XXXXXX will be cleaned on next startup,
 /etc/pw.XXXXX and especially /path/to/unknown/pw.XXXXXX - never.
 Rice working on /var/run but not on /etc ? Hmm.
 
 >What is the problem you are trying to solve?
 You probably suggest do something like:
 sudo less /etc/master.passwd
 sudo mount -uw /
 sudo vipw
 ?
 
 One more line for sudoers. One more time type password.
 Perhaps.
 
 --
 Adios