From owner-freebsd-current@FreeBSD.ORG Sat Feb 2 14:50:18 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8D7A2A97; Sat, 2 Feb 2013 14:50:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id DB51A6A5; Sat, 2 Feb 2013 14:50:17 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r12EoDIg077606; Sat, 2 Feb 2013 16:50:13 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.4 kib.kiev.ua r12EoDIg077606 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r12EoDq1077604; Sat, 2 Feb 2013 16:50:13 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Feb 2013 16:50:13 +0200 From: Konstantin Belousov To: Andriy Gapon Subject: Re: scheduler->swapper, SI_SUB_RUN_SCHEDULER->SI_SUB_LAST Message-ID: <20130202145013.GV2522@kib.kiev.ua> References: <510CFD90.9000304@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0ujaWV404FI0kHa9" Content-Disposition: inline In-Reply-To: <510CFD90.9000304@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-hackers@FreeBSD.org, freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2013 14:50:18 -0000 --0ujaWV404FI0kHa9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 02, 2013 at 01:50:40PM +0200, Andriy Gapon wrote: >=20 > I would like to propose the following mostly cosmetic change: > http://people.freebsd.org/~avg/scheduler-swapper.diff >=20 > This is something that bit me early in my FreeBSD days, so I am kind of o= bsessed > with it. > The current naming is confusing/misleading indeed. > And magic properties of SI_SUB_RUN_SCHEDULER:SI_ORDER_LAST is a "hidden g= em". You may remove the Giant unlock from the scheduler()/swapper() as well then, doing it before the swapper() call in the mi_startup(). Note that the wait chain for the idle swapper is still called "sched". --0ujaWV404FI0kHa9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRDSelAAoJEJDCuSvBvK1B6usP/i4nVfbHVB++Sk8BUy5+zrIM B+dAEnb64hEnELVjcQfAYO7+UDkgMMo63eVmgq8kYtiVBJ7bF6+QxbjNObubXM7B 0MbLpcHgnwtwuqMF4swVofJzR7pqbqo7lq3E5R9Bd57kZJfhzNS7CPhycX4HQiV0 WZZB1SLz+eoc+jfyFgOSfR+Eq9hrrPS2lH2k76FwScU1x0IpiTnkaYkfcs0QYqgW z0AqRmQjAEl9V8HyM4b2qTa+6k0K+HiXaQMNzpn+GZhlpjmmVe7pQy2fy/5NBAzU rK0dxu2J0FH1PEJgLwJIIlMYl0MI3KjeX1O4QmCkQLros0o6+ZwQ7t0irRsydGsX dJI7T57i3+BZvo61Uq3snFRbkiIBKhUtnwTBWF9z+qSJW10Ma+UcASltN0/6YFhP trdcVqbN4jsOLpYTAGBLgxzf4LjqzVHeNPX3wmL42LfFXmwPm7mYbbKsucbfxFCQ WJvbJCvo/PMzwHCK+aC0UueZ1yI8nx95oGp+HWQGc6AgD9PmmzWMZng9gAdUK5kO +v1S4t7aQymjASwUtNpHZnjC+keQy/Zk/L7GT0mveD0hm7+jtlAKqzBkqTS/7dfJ yba9uoxT3gZpYkEA7GmSerERJfDvXAF1azYUdzhk9Kcu8lX8OTvsov0xjUrXIL5J 9oH+HRNGtfKWsdN2QH1y =qdWH -----END PGP SIGNATURE----- --0ujaWV404FI0kHa9--