From owner-freebsd-stable Fri Jun 30 6:51:17 2000 Delivered-To: freebsd-stable@freebsd.org Received: from sabre.velocet.net (sabre.velocet.net [198.96.118.66]) by hub.freebsd.org (Postfix) with ESMTP id B95EA37B66F for ; Fri, 30 Jun 2000 06:51:14 -0700 (PDT) (envelope-from dgilbert@office.tor.velocet.net) Received: from office.tor.velocet.net (trooper.velocet.net [216.126.82.226]) by sabre.velocet.net (Postfix) with ESMTP id AB8A5137F1A for ; Fri, 30 Jun 2000 09:51:13 -0400 (EDT) Received: (from dgilbert@localhost) by office.tor.velocet.net (8.9.3/8.9.3) id JAA80877; Fri, 30 Jun 2000 09:51:13 -0400 (EDT) (envelope-from dgilbert) From: David Gilbert MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <14684.42449.103888.380937@trooper.velocet.net> Date: Fri, 30 Jun 2000 09:51:13 -0400 (EDT) To: freebsd-stable@freebsd.org Subject: Re: dc19 fructration. In-Reply-To: <200006300024.KAA01770@lightning.itga.com.au> References: <200006300024.KAA01770@lightning.itga.com.au> X-Mailer: VM 6.75 under 20.4 "Emerald" XEmacs Lucid Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Solved. PR 19603. Probably should be MFC'd all over the place. I'm not 100% satisfied with the patch. I don't understand the operation of SYSCTL_STRUCT() enough to make it allocatate things dynamically --- it probably should. As evidenced by the printf(), it knows the number of interfaces it's got right before it bzero()'s the block to initialize it. The biggest insult was that BDG_MAX_PORTS was defined ... and used elsewhere in the code, but that a static 16 entries was allocated in the status struct (and not range checked anywhere). Dave. -- ============================================================================ |David Gilbert, Velocet Communications. | Two things can only be | |Mail: dgilbert@velocet.net | equal if and only if they | |http://www.velocet.net/~dgilbert | are precisely opposite. | =========================================================GLO================ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message