From owner-freebsd-arch@FreeBSD.ORG Tue Dec 12 14:48:03 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 60E1E16A4D1 for ; Tue, 12 Dec 2006 14:48:03 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5E7344325 for ; Tue, 12 Dec 2006 14:41:40 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id kBCEgkiT062153; Tue, 12 Dec 2006 06:42:46 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id kBCEgknB062152; Tue, 12 Dec 2006 06:42:46 -0800 (PST) (envelope-from rizzo) Date: Tue, 12 Dec 2006 06:42:46 -0800 From: Luigi Rizzo To: arch@freebsd.org Message-ID: <20061212064246.A62035@xorpc.icir.org> References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> <20061212062445.A61903@xorpc.icir.org> <20061212143113.GA54209@cicely12.cicely.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20061212143113.GA54209@cicely12.cicely.de>; from ticso@cicely12.cicely.de on Tue, Dec 12, 2006 at 03:31:13PM +0100 Cc: Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 14:48:03 -0000 [moving to arch] sorry if it has been debated already, but looking in the network code it seems that checks for architectures that need strong alignment are done through a sequence of #if defined(__ia64__) || defined(__blah__) || ... one such sequence is in net/if_loop::if_simloop(), and was related to a problem we are having with some recent commits to net/if_ethersubr.c While the easy fix (for this one) is to add || defined(__arm__) to the sequence, we were wondering if there is some identifier that we can use to the purpose. Bernd Walter was suggesting this: > I would have said ALIGNBYTES != 1, but this also matches with i386. > Guess it's time to introduce somehing like ALIGN_STRONG, or whatever > colour fits best. ideas ? cheers luigi