From owner-freebsd-jail@FreeBSD.ORG Mon May 4 13:17:58 2009 Return-Path: Delivered-To: jail@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA40E106566B; Mon, 4 May 2009 13:17:58 +0000 (UTC) (envelope-from jamie@FreeBSD.org) Received: from gritton.org (gritton.org [161.58.222.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8EB8C8FC21; Mon, 4 May 2009 13:17:58 +0000 (UTC) (envelope-from jamie@FreeBSD.org) Received: from glorfindel.gritton.org (c-76-27-80-223.hsd1.ut.comcast.net [76.27.80.223]) (authenticated bits=0) by gritton.org (8.13.6.20060614/8.13.6) with ESMTP id n44DHu8T003446; Mon, 4 May 2009 07:17:57 -0600 (MDT) Message-ID: <49FEEB03.7060908@FreeBSD.org> Date: Mon, 04 May 2009 07:17:55 -0600 From: Jamie Gritton User-Agent: Thunderbird 2.0.0.19 (X11/20090220) MIME-Version: 1.0 To: Poul-Henning Kamp References: <4424.1241418320@critter.freebsd.dk> In-Reply-To: <4424.1241418320@critter.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.94.2/9325/Mon May 4 06:17:20 2009 on gritton.org X-Virus-Status: Clean Cc: virtualization@FreeBSD.org, jail@FreeBSD.org, current@FreeBSD.org Subject: Re: New jail framework - the userland side X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2009 13:17:59 -0000 Poul-Henning Kamp wrote: > In message <49FE5387.3020503@FreeBSD.org>, Jamie Gritton writes: > >> Hi all. I recently added some new jail-related system calls to extend >> the current jail system with an nmount-inspired name=value interface. > > I think this is a great move in the right direction, my only concern is > that we should try to share as much of the string-munging code between > the nmount and jail implementations as possible. Most if it is shared - jail actually calls vfs_getopt and related calls from the family. I might want to spin those functions off into their own subsystem at some point, now that they're officially used outside of VFS. I did have to extend things somewhat for jail_get, as nmount is write- only and only had to deal with one module at a time (the filesystem type). Those extensions are available for use elsewhere, as I suspect filesystems and jails aren't the only place where we could use name- based extensibility. - Jamie