From owner-svn-src-all@FreeBSD.ORG Mon Oct 22 14:35:28 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D84BBC4 for ; Mon, 22 Oct 2012 14:35:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id D55198FC14 for ; Mon, 22 Oct 2012 14:35:27 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fw7so3806346vcb.13 for ; Mon, 22 Oct 2012 07:35:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=67jgHo2W1A2U+Az1TLS1v+CA2NXyVxZxxs+nW5OQf4w=; b=YZL6hwB9wsTO7PAMtxFlPsZUzpyylp70bRpsqRofiqrfy50ToFUb/D8IEHScU6NHl6 f86fLARFbvYZkfFT6lMVli9K270+0ySLcUuh4eM5C8rYHyFwT7rQEyjmoNWFmfLukqE4 Xjm65nDEMAYYNjBW9E1MFtJpbasIKK9r8iCpiNWk0buceZSHRzmUqKovK6LEZgpKJAck z4c6TzWBH4H45YhjQMRPg7z95xncbpz+tVO9KcEHdA7BgBTmVt4kitZnq3XCxRE9R8YS PGH9qQJSHjAWk2QpJeJDy3D3J9DsqSh7uESHTYrAm5JDQ7E2IarbelnrL5UKovF+Y9H/ x1rg== Received: by 10.52.68.7 with SMTP id r7mr12146355vdt.96.1350916526905; Mon, 22 Oct 2012 07:35:26 -0700 (PDT) Received: from [10.30.101.53] ([209.117.142.2]) by mx.google.com with ESMTPS id r6sm10313123vdj.8.2012.10.22.07.35.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Oct 2012 07:35:23 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r241755 - head/lib/msun/src Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20121022134003.GA52156@troutmask.apl.washington.edu> Date: Mon, 22 Oct 2012 08:35:17 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <45589524-E249-43E3-91B7-6A78068208AD@bsdimp.com> References: <201210192246.q9JMkm4R092929@svn.freebsd.org> <20121020150917.I1095@besplex.bde.org> <18177777-6EE0-4103-98B0-272EFF98FE96@bsdimp.com> <20121022040651.GA49632@troutmask.apl.washington.edu> <20121022134003.GA52156@troutmask.apl.washington.edu> To: Steve Kargl X-Mailer: Apple Mail (2.1084) X-Gm-Message-State: ALoCoQlc0vlBQSX2ioxJJRoEHfH1472T7RPwVVBwNJS0myAZdVFz/X8F5Q9u1zxIeR2GnyCD59o4 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh , Bruce Evans X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 14:35:28 -0000 On Oct 22, 2012, at 7:40 AM, Steve Kargl wrote: > On Mon, Oct 22, 2012 at 06:59:04AM -0600, Warner Losh wrote: >>=20 >> On Oct 21, 2012, at 10:06 PM, Steve Kargl wrote: >>=20 >>> On Sun, Oct 21, 2012 at 09:08:49PM -0600, Warner Losh wrote: >>>> Feel free to fix them however. I added the comments because >>>> the algorithms weren't quite the same... If you have a better >>>> way, feel free to back my stuff out on the way to it. >>>>=20 >>>> Warner >>>>=20 >>>=20 >>> Please back your commits out.=20 >>>=20 >>> Two of the three people who actually appear to be >>> working on libm have now requested the back-out. >>=20 >> OK. While it would be just as easy for you guys to commit the new = stuff over mine, I'll revert them. >>=20 >> Warner >>=20 >=20 > Thanks. >=20 > BTW, besides bde's technical points, your change made > our sources different from OpenBSD, NetBSD, and new > project openlibm. Diffing against the other trees > would become cluttered. BDE's technical points vary in quality and are difficult to argue with = since they are so nit-picky. :( I'd be happy to work through them, but = some of the issues I just fundamentally disagree with. Since I backed = out the comments, I've decided not to spend the time arguing, but do = think that documenting the differences between the precisions would be = good. I started down this path because I thought expf was broken = because it didn't match exp exactly... However, since he's implementing a new one, wouldn't that also have = diffability issues too? Warner=