Date: Tue, 22 Feb 2005 16:51:25 GMT From: Peter Lavee <pbl@tsua.net> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/77929: periodic/security/550.ipfwlimit ignores logamount Message-ID: <200502221651.j1MGpODG088804@www.freebsd.org> Resent-Message-ID: <200502221700.j1MH0Xms011252@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 77929
>Category: misc
>Synopsis: periodic/security/550.ipfwlimit ignores logamount
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 22 17:00:33 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Peter Lavee
>Release: FreeBSD 4.11-RELEASE
>Organization:
Technological Systems CJVC
>Environment:
FreeBSD ns.hau.org.ua 4.11-RELEASE FreeBSD 4.11-RELEASE #1: Thu Jan 27 20:26:44 EET 2005 root@ns.hau.org.ua:/var/uobj/usr/src/sys/NSAPM i386
>Description:
550.ipfwlimit check in /etc/periodic/security takes into account only
global/default verbosity limit and does not account for a specific
logging limit set for a particular rule e.g.:
$ ipfw -a l | fgrep log
65000 *521* 41764 deny log logamount *1000* ip from any to any
$ sysctl -n net.inet.ip.fw.verbose_limit
*100*
>From security run output:
ipfw log limit reached:
65000 519 41672 deny log logamount 1000 ip from any to any
>How-To-Repeat:
just use logamount value bigger than net.inet.ip.fw.verbose_limit
>Fix:
cat >/etc/periodic/security/550.ipfwlimit
#!/bin/sh -
#
# Copyright (c) 2001 The FreeBSD Project
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
#
# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
# SUCH DAMAGE.
#
# $FreeBSD: src/etc/periodic/security/550.ipfwlimit,v 1.2.2.3 2002/08/28 05:13:53 cjc Exp $
#
# Show ipfw rules which have reached the log limit
#
# If there is a global system configuration file, suck it in.
#
if [ -r /etc/defaults/periodic.conf ]
then
. /etc/defaults/periodic.conf
source_periodic_confs
fi
rc=0
case "$daily_status_security_ipfwlimit_enable" in
[Yy][Ee][Ss])
TMP=`mktemp ${TMPDIR:-/tmp}/security.XXXXXXXXXX`
IPFW_LOG_LIMIT=`sysctl -n net.inet.ip.fw.verbose_limit 2> /dev/null`
if [ $? -eq 0 ] && [ "${IPFW_LOG_LIMIT}" -ne 0 ]; then
ipfw -a l | grep " log " | grep -v " logamount " | perl -n -e \
'/^\d+\s+(\d+)/; print if ($1 >= '$IPFW_LOG_LIMIT')' > ${TMP}
ipfw -a l | grep " log " | grep " logamount " | perl -n -e \
'/^\d+\s+(\d+).+?logamount\s+(\d+)/; print if ($1 >= $2)' >> ${TMP}
if [ -s "${TMP}" ]; then
rc=1
echo ""
echo 'ipfw log limit reached:'
cat ${TMP}
fi
fi
rm -f ${TMP};;
*) rc=0;;
esac
exit $rc
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502221651.j1MGpODG088804>