Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Sep 2012 16:53:05 +0400
From:      Sergey Kandaurov <pluknet@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r240646 - head/sys/contrib/altq/altq
Message-ID:  <CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ@mail.gmail.com>
In-Reply-To: <201209181234.q8ICYaFB091109@svn.freebsd.org>
References:  <201209181234.q8ICYaFB091109@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 18 September 2012 16:34, Gleb Smirnoff <glebius@freebsd.org> wrote:
> Author: glebius
> Date: Tue Sep 18 12:34:35 2012
> New Revision: 240646
> URL: http://svn.freebsd.org/changeset/base/240646
>
> Log:
>   Do more than r236298 did in the projects/pf branch: use M_NOWAIT in
>   altq_add() and its descendants. Currently altq(4) in FreeBSD is configured
>   via pf(4) ioctls, which can't configure altq(4) w/o holding locks.
>   Fortunately, altq(4) code in spife of using M_WAITOK is ready to receive
>   NULL from malloc(9), so change is mostly mechanical. While here, utilize
>   M_ZERO instead of bzero().
>
>   A large redesign needed to achieve M_WAITOK usage when configuring altq(4).
>   Or an alternative (not pf(4)) configuration interface should be implemented.
>
>   Reported by:  pluknet

Actually Kim Culhan was initial reporter.
I just reposted the problem closer to glebius and pointed out the roots.

-- 
wbr,
pluknet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ>