From owner-svn-src-all@FreeBSD.ORG Tue Sep 18 12:53:06 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BEA831065670; Tue, 18 Sep 2012 12:53:06 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5C5B08FC0C; Tue, 18 Sep 2012 12:53:06 +0000 (UTC) Received: by iayy25 with SMTP id y25so7784849iay.13 for ; Tue, 18 Sep 2012 05:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=9q45l/hesWue2eCBAFwuc8uIiLp1sZy+N0wOJXZ0hRI=; b=AQ8bPd1U8+AYaEwHswGDTvQATgU2+Zz3+yOSn+RLaWxUfwKxyDPIFi66bZrQqAeNNs 2T30Ubw4vX8G8uRRUgCXF7Vju0QzQQHPOjP0/iy812HB9iqovlzrLf57lXU+0BUtEI/q 3uBa+VHxhYkM5p51qOIGvyPtpwrS3xywW8ck/oS6zkcIFS+4hmRlk7QvAw/GCrh5REj9 dGflk0ia2cq1MDujA65n0o1B2KR2vE5SiEt4ikkq2OhE16bDhU23pZpVE6hoAEVRC0zw JjivphlocvtULgnj4cYIg09xAQo7rkqatjH4y+Ul6+ayke1BHs/6qoAoo+O8NRDq6g8B S27Q== MIME-Version: 1.0 Received: by 10.43.48.129 with SMTP id uw1mr97572icb.10.1347972785780; Tue, 18 Sep 2012 05:53:05 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.64.165.34 with HTTP; Tue, 18 Sep 2012 05:53:05 -0700 (PDT) In-Reply-To: <201209181234.q8ICYaFB091109@svn.freebsd.org> References: <201209181234.q8ICYaFB091109@svn.freebsd.org> Date: Tue, 18 Sep 2012 16:53:05 +0400 X-Google-Sender-Auth: Zd_k75c10pjoiIRwA3zfjnVWf-4 Message-ID: From: Sergey Kandaurov To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240646 - head/sys/contrib/altq/altq X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2012 12:53:06 -0000 On 18 September 2012 16:34, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Sep 18 12:34:35 2012 > New Revision: 240646 > URL: http://svn.freebsd.org/changeset/base/240646 > > Log: > Do more than r236298 did in the projects/pf branch: use M_NOWAIT in > altq_add() and its descendants. Currently altq(4) in FreeBSD is configured > via pf(4) ioctls, which can't configure altq(4) w/o holding locks. > Fortunately, altq(4) code in spife of using M_WAITOK is ready to receive > NULL from malloc(9), so change is mostly mechanical. While here, utilize > M_ZERO instead of bzero(). > > A large redesign needed to achieve M_WAITOK usage when configuring altq(4). > Or an alternative (not pf(4)) configuration interface should be implemented. > > Reported by: pluknet Actually Kim Culhan was initial reporter. I just reposted the problem closer to glebius and pointed out the roots. -- wbr, pluknet