From owner-freebsd-scsi@freebsd.org Sun Nov 6 19:42:06 2016 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 447BFC329EB for ; Sun, 6 Nov 2016 19:42:06 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 259D7B03; Sun, 6 Nov 2016 19:42:05 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.6] (67-0-232-116.albq.qwest.net [67.0.232.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 53B401928BA; Sun, 6 Nov 2016 19:41:58 +0000 (UTC) Subject: Re: mpt driver issue? To: Michael Tuexen , freebsd-scsi@freebsd.org References: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org> Cc: scottl@freebsd.org From: Sean Bruno Message-ID: Date: Sun, 6 Nov 2016 12:41:54 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gmUQojcTriqElfHw5E40dTo5GAuJHxakc" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2016 19:42:06 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gmUQojcTriqElfHw5E40dTo5GAuJHxakc Content-Type: multipart/mixed; boundary="rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu"; protected-headers="v1" From: Sean Bruno To: Michael Tuexen , freebsd-scsi@freebsd.org Cc: scottl@freebsd.org Message-ID: Subject: Re: mpt driver issue? References: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org> In-Reply-To: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org> --rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/06/16 10:54, Michael Tuexen wrote: > Dear all, >=20 > it was suggested on current@ to forward this to freebsd-scsi@ >=20 > The problem shows up since r308268 and it looks like an issue > in the mpt driver... >=20 > Best regards > Michael I don't see any *obvious* reason that we should hold the mpt lock here. It looks ok to just drop it. sean Index: sys/dev/mpt/mpt.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/mpt/mpt.c (revision 308345) +++ sys/dev/mpt/mpt.c (working copy) @@ -2284,9 +2284,7 @@ mpt_lprt(mpt, MPT_PRT_DEBUG, "doorbell req =3D %s\n", mpt_ioc_diag(mpt_read(mpt, MPT_OFFSET_DOORBELL))); - MPT_LOCK(mpt); error =3D mpt_configure_ioc(mpt, 0, 0); - MPT_UNLOCK(mpt); return (error); } --rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu-- --gmUQojcTriqElfHw5E40dTo5GAuJHxakc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQF8BAEBCgBmBQJYH4eCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kBl8H+wXvTw6UNz60CCSQKDBXyutj ZfdbbSwf1clyM3dfUTPlVY87cSS5gnaNE2D4pFgnb0uum+5pH4YC+M9or/eSHIHp yw/FLvwNZS3uWk4meAq1s+9hEXnUHvsFiry9cssklrLtKS2bn8BhDCzJdPnq58U5 oOn74eNUMep5EeFLtFjkX3jEAuZBghQzcnymCHftcaNGM4PXIi5PVKOMnLiiyWkS UaS4SYIrH9TNNnjYCFQ56ScE3zz5Gnl8Q+hDk20r37Uk1QQAkR+bzkeaPrVD+Qu6 IFjF5U0mp7AQ+md2DbcfBJN3gDTHc94gHMBbgFjXbkfgDcrQGAoagh9HNWG/Vpw= =qWMX -----END PGP SIGNATURE----- --gmUQojcTriqElfHw5E40dTo5GAuJHxakc--