Date: Wed, 4 Jun 1997 16:48:03 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Paul Traina <pst@shockwave.com> Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa sio.c sioreg.h Message-ID: <Pine.BSF.3.95q.970604164405.394E-100000@herring.nlsystems.com> In-Reply-To: <199706041537.IAA09916@precipice.shockwave.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 4 Jun 1997, Paul Traina wrote:
>
> From: Doug Rabson <dfr@nlsystems.com>
> Subject: Re: cvs commit: src/sys/i386/isa sio.c sioreg.h
> On Tue, 3 Jun 1997, Paul Traina wrote:
>
> > pst 1997/06/03 21:52:41 PDT
> >
> > Modified files:
> > sys/i386/isa sio.c sioreg.h
> > Log:
> > If the boot blocks were using the serial port, read the system console
> > speed using the boot blocks, instead of a hardcoded value stuck in the
> > kernel. This way, you can have systems using the same kernel but differe
> >>nt
> > console speeds.
> >
> > Add a sysctl entry for changing the system console speed.
> > Lock the user tty speed to match the system console speed.
> >
> > Nuke CONSPEED.
>
> What about when you are using the port for serial gdb and didn't boot from
> it? What speed will it be set to then? I often use serial gdb way before
> I can think about setting the speed with sysctl and debugging over 9600 is
> pointlessly painful.
>
> That's what the sysctl is for.
Did you read what I wrote? I boot the kernel with -d so that I can debug
device configuration. How do you expect me to run sysctl when the system
hasn't finished booting? Debugging at 9600 baud sucks big time.
This patch restores the (IMHO) correct behaviour for serial debugging.
Index: sio.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/isa/sio.c,v
retrieving revision 1.170
diff -u -r1.170 sio.c
--- sio.c 1997/06/04 04:52:39 1.170
+++ sio.c 1997/06/04 15:46:45
@@ -2621,6 +2621,10 @@
if (boot_speed)
comdefaultrate = boot_speed;
}
+#ifdef CONSPEED
+ else
+ comdefaultrate = CONSPEED;
+#endif
siocnopen(&sp);
splx(s);
if (!COM_LLCONSOLE(dvp)) {
--
Doug Rabson Mail: dfr@nlsystems.com
Nonlinear Systems Ltd. Phone: +44 181 951 1891
Fax: +44 181 381 1039
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95q.970604164405.394E-100000>