From owner-cvs-all Fri Dec 4 11:55:08 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA13154 for cvs-all-outgoing; Fri, 4 Dec 1998 11:55:08 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA13145; Fri, 4 Dec 1998 11:55:06 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.1/8.9.1) id LAA16937; Fri, 4 Dec 1998 11:54:40 -0800 (PST) (envelope-from dillon) Date: Fri, 4 Dec 1998 11:54:40 -0800 (PST) From: Matthew Dillon Message-Id: <199812041954.LAA16937@apollo.backplane.com> To: Bruce Evans Cc: ache@nagual.pp.ru, dillon@apollo.backplane.com, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h References: <199812040900.UAA15573@godzilla.zeta.org.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk : :> I really do not want to throw multiple externs into the code, and I :> can't localize the rate limit to the icmp module because there is a :> critical piece in the tcp module that rate-limits dropwithreset for :> SYN's received to non-existent ports (a common attack mode) which has :> nothing to do with ICMP packets. : :In that case, the prototype shouldn't be declared in an icmp header and :the option name shouldn't begin with ICMP. : :Bruce Well, most uses of the code are related to ICMP responses. The TCP case is a special case. Boy, that's real helpful Bruce. If you have a *solution* you want to share with us, be my guest! -Matt Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message