From owner-freebsd-ports@FreeBSD.ORG Mon Jun 21 07:09:31 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4286616A4CE for ; Mon, 21 Jun 2004 07:09:31 +0000 (GMT) Received: from atlas.informatik.rwth-aachen.de (atlas.informatik.RWTH-Aachen.DE [137.226.194.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D55F43D39 for ; Mon, 21 Jun 2004 07:09:30 +0000 (GMT) (envelope-from stolz@i2.informatik.rwth-aachen.de) Received: from menelaos.informatik.rwth-aachen.de (menelaos.informatik.RWTH-Aachen.DE [137.226.194.73]) 8.11.1-0.5-michaelw-20030918) with ESMTP id i5L78m429965; Mon, 21 Jun 2004 09:08:48 +0200 Received: (from stolz@localhost)i5L78mhC079314; Mon, 21 Jun 2004 09:08:48 +0200 (CEST) (envelope-from stolz) Date: Mon, 21 Jun 2004 09:08:48 +0200 From: Volker Stolz To: Anish Mistry Message-ID: <20040621070848.GA78206@i2.informatik.rwth-aachen.de> References: <20040620232712.GA75329@fajita.org> <200406202328.06979.mistry.7@osu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200406202328.06979.mistry.7@osu.edu> X-PGP-Key: finger vs@foldr.org X-PGP-Id: 0x3FD1B6B5 User-Agent: Mutt/1.5.4i cc: ports@FreeBSD.org cc: lewiz@fajita.org cc: lars.eggert@gmx.net Subject: Re: Freevo port (TESTING REQUIRED). X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2004 07:09:31 -0000 In local.freebsd-ports, you wrote: >> I've been working on a port of Freevo (http://freevo.sf.net/), which is >> ``an open-source home theatre PC platform'', for a while now and >> hopefully within a week or two version 1.5.0 will be released. >> >> In addition to my Freevo port it's important you have a very recent >> version of mmpython. If you already have this installed, please upgrade >> -- it includes some critical disc-specific updates, without which the >> DVD stuff will really not work right (you'll get 4(c)!). If you CVSuped >> in the last couple of days you should be fine. Please check if this could be encoded in the dependencies somehow...it might be possible to (ab)use CONFLICTS for this, but that might be over the top. > I hope you checked the freevo port skeleton submission in the PR database. > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/59047 Lewis' submission looks more complete to me. I'd say go ahead and send-pr. Please fix some of the deficiencies reported by portlint before, most notably: 1) WARN: /usr/tmp/freevo/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should be used. FATAL: Makefile: PORTVERSION looks illegal. You should modify "1.5.0rc3". Both are errors in you port. 2) Regarding the required user-ids, please read: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-uid.html 3) I don't understand your WITH-handling: .if !defined(WITH_MPLAYER) WITH_MPLAYER= yes .endif .if !defined(WITH_XINE) WITH_XINE= yes .endif Please also consider using OPTIONS. -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME Neu! Ändern Sie den Anfangstag Ihrer Woche