From owner-freebsd-usb@freebsd.org Wed Sep 5 10:08:31 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D4ECFEAFF9 for ; Wed, 5 Sep 2018 10:08:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0A1347A9D0 for ; Wed, 5 Sep 2018 10:08:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BF66EFEAFF8; Wed, 5 Sep 2018 10:08:30 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE387FEAFF7 for ; Wed, 5 Sep 2018 10:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F9627A9CE for ; Wed, 5 Sep 2018 10:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id AE14B17AE5 for ; Wed, 5 Sep 2018 10:08:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w85A8Tk1048108 for ; Wed, 5 Sep 2018 10:08:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w85A8TKd048107 for usb@FreeBSD.org; Wed, 5 Sep 2018 10:08:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 231076] libusb_cancel_transfer() does NOT cancel a transfer after the USB device is removed Date: Wed, 05 Sep 2018 10:08:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 10.4-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ludovic.rousseau+freebsd@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 10:08:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231076 --- Comment #9 from Ludovic Rousseau -= -- When the USB device is removed libusb10_handle_events_sub() will call libusb10_cancel_all_transfer() at https://github.com/freebsd/freebsd/blob/master/lib/libusb/libusb10_io.c#L170 libusb10_cancel_all_transfer() will then call libusb20_tr_close() at https://github.com/freebsd/freebsd/blob/master/lib/libusb/libusb10.c#L1570 libusb20_tr_close() will then reset the variable fields at https://github.com/freebsd/freebsd/blob/master/lib/libusb/libusb20.c#L142 So when libusb_cancel_transfer() is called by my code the fields priv_sc0 a= nd priv_sc1 are already reset to 0 and libusb_cancel_transfer() returns LIBUSB_ERROR_NOT_FOUND in https://github.com/freebsd/freebsd/blob/master/lib/libusb/libusb10.c#L1547 I can test any patch you propose to fix the issue. --=20 You are receiving this mail because: You are the assignee for the bug.=