From owner-cvs-all Tue Nov 27 13:58:24 2001 Delivered-To: cvs-all@freebsd.org Received: from c527597-a.cstvl1.sfba.home.com (c527597-a.cstvl1.sfba.home.com [24.176.204.87]) by hub.freebsd.org (Postfix) with ESMTP id A6EAB37B405; Tue, 27 Nov 2001 13:58:14 -0800 (PST) Received: (from bmah@localhost) by c527597-a.cstvl1.sfba.home.com (8.11.6/8.11.6) id fARLwEp62297; Tue, 27 Nov 2001 13:58:14 -0800 (PST) (envelope-from bmah) Message-Id: <200111272158.fARLwEp62297@c527597-a.cstvl1.sfba.home.com> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Robert Watson Cc: Mike Barcroft , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Committer's guide policy on commit message contents In-Reply-To: References: Comments: In-reply-to Robert Watson message dated "Tue, 27 Nov 2001 16:37:49 -0500." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_-2045023344P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 27 Nov 2001 13:58:14 -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --==_Exmh_-2045023344P Content-Type: text/plain; charset=us-ascii If memory serves me right, Robert Watson wrote: > > On Tue, 27 Nov 2001, Mike Barcroft wrote: > > > From the Committers Guide: "Do not waste space in the commit messages > > explaining what you did. That is what cvs diff is for. Instead, tell > > us why you did it." > > Ignoring, for a moment, any context -- I think this is actually not a good > policy. In the event that there are complex or large changes being made, > a brief summary of the changes, along with the rationale, is appropriate > in the commit message. At least, that's my feeling :-). Is this > something that would be worth changing? Most emphatically, yes. If I have to interpret a diff for some random piece of code just to write a release notes entry, it probably isn't going to happen. Bruce. --==_Exmh_-2045023344P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: Exmh version 2.3.1+ 05/14/2001 iD8DBQE8BAx22MoxcVugUsMRAurEAJ4wseF+DxZ63C8gOXt1DPmTs9z1cACfQfho tSSdoBcyy5telK0ZSaHdRug= =4mUN -----END PGP SIGNATURE----- --==_Exmh_-2045023344P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message