From owner-freebsd-current@freebsd.org Sat Jun 11 13:40:35 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9219EAEF331 for ; Sat, 11 Jun 2016 13:40:35 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.auburn.protected-networks.net (mail.auburn.protected-networks.net [IPv6:2001:470:1f07:4e1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.auburn.protected-networks.net", Issuer "Protected Networks Root CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6531D2D54 for ; Sat, 11 Jun 2016 13:40:35 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: imb@mail.auburn.protected-networks.net) by mail.auburn.protected-networks.net (Postfix) with ESMTPSA id 65A701CC1C; Sat, 11 Jun 2016 09:40:33 -0400 (EDT) To: freebsd-current Cc: "M. Warner Losh" From: Michael Butler Subject: smartmontools now broken on -current (by svn r301771, r301778?) Openpgp: id=6F63E6399DCC8E3E94D60F0642FF6BAE0442D492 Message-ID: Date: Sat, 11 Jun 2016 09:40:31 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2016 13:40:35 -0000 The recent nvme updates have broken smartmontools .. imb@toshi:/home/imb> sudo smartctl -a /dev/ada0 smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-ALPHA2 amd64] (local build) Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org /dev/ada0: Inappropriate ioctl for device Please specify device type with the -d option. Attempts to recompile the utility also fail: c++ -DHAVE_CONFIG_H -I. -DBUILD_INFO='"(local build)"' -DSMARTMONTOOLS_SYSCONFDIR='"/usr/local/etc"' -DSMARTMONTOOLS_SMARTDSCRIPTDIR='"/usr/local/etc"' -DSMARTMONTOOLS_DRIVEDBDIR='"/usr/local/share/smartmontools"' -O2 -pipe -march=core2 -fstack-protector -fno-strict-aliasing -Wall -W -c -o cciss.o cciss.cpp In file included from os_freebsd.cpp:43: ./atacmds.h:77:9: warning: 'ATA_SET_FEATURES' macro redefined [-Wmacro-redefined] #define ATA_SET_FEATURES 0xef ^ /usr/include/sys/ata.h:399:10: note: previous definition is here #define ATA_SET_FEATURES 0x05 /* set features */ ^ In file included from os_freebsd.cpp:74: ./freebsd_nvme_ioctl.h:34:8: error: redefinition of 'nvme_command' struct nvme_command ^ /usr/include/dev/nvme/nvme.h:201:8: note: previous definition is here struct nvme_command ^ In file included from os_freebsd.cpp:74: ./freebsd_nvme_ioctl.h:67:8: error: redefinition of 'nvme_status' struct nvme_status { ^ /usr/include/dev/nvme/nvme.h:234:8: note: previous definition is here struct nvme_status { ^ In file included from os_freebsd.cpp:74: ./freebsd_nvme_ioctl.h:77:8: error: redefinition of 'nvme_completion' struct nvme_completion { ^ /usr/include/dev/nvme/nvme.h:244:8: note: previous definition is here struct nvme_completion { ^ In file included from os_freebsd.cpp:74: ./freebsd_nvme_ioctl.h:94:8: error: redefinition of 'nvme_pt_command' struct nvme_pt_command { ^ /usr/include/dev/nvme/nvme.h:765:8: note: previous definition is here struct nvme_pt_command { ^ 1 warning and 4 errors generated.