From owner-dev-commits-src-main@freebsd.org  Thu Jul 22 16:32:21 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13DE365FE3F;
 Thu, 22 Jul 2021 16:32:21 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GVyfD6MZHz3smW;
 Thu, 22 Jul 2021 16:32:20 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [178.17.145.105])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 5A60A2600F3;
 Thu, 22 Jul 2021 18:32:12 +0200 (CEST)
Subject: Re: git: 6c9506559080 - main - Escape any '.' characters in sysctl
 node names
To: Alan Somers <asomers@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202107221623.16MGNZDu023290@gitrepo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <9fe74162-d1f9-623c-3a9e-d41139729aab@selasky.org>
Date: Thu, 22 Jul 2021 18:32:00 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <202107221623.16MGNZDu023290@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4GVyfD6MZHz3smW
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2021 16:32:21 -0000

On 7/22/21 6:23 PM, Alan Somers wrote:
> commit 6c9506559080da2914749bf611225d7c0a153609
> Author:     Alan Somers<asomers@FreeBSD.org>
> AuthorDate: 2021-07-21 21:11:00 +0000
> Commit:     Alan Somers<asomers@FreeBSD.org>
> CommitDate: 2021-07-22 16:22:48 +0000

If the strings come from user-input or hardware, why not just allow a-z 
and 0-9 and a few other characters?

There are surely more illegal characters than just '.', like \n \r \t 
<space> that we don't want to see in sysctl names.

--HPS