From owner-cvs-sys  Fri Jul 25 06:55:42 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id GAA04015
          for cvs-sys-outgoing; Fri, 25 Jul 1997 06:55:42 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA04002;
          Fri, 25 Jul 1997 06:55:25 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id XAA06472; Fri, 25 Jul 1997 23:50:53 +1000
Date: Fri, 25 Jul 1997 23:50:53 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199707251350.XAA06472@godzilla.zeta.org.au>
To: bde@zeta.org.au, smp@csn.net
Subject: Re: cvs commit: src/sys/sys lock.h src/sys/i386/include param.h smp.h src/sys/i386/isa apic_ipl.s apic_vector.s ipl.s src/sys/i386/i386 exception.s mp_machdep.c mpapic.c
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG,
        fsmp@FreeBSD.ORG
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>> >  Modified files:
>> >    sys/i386/include     param.h smp.h 
>> >  Log:
>> >  Forced 32bit alignment of struct simple_lock in param.h.
>> 
>> Alignment of the machine-dependent struct was already guaranteed, since
>> the struct contains an int, and 32-bit alignment of ints is guaranteed
>> in practice (although the CPU does not require it) since misalignment
>> would be inefficient.
>
>this I disagree with.  I think of it as a comment, forcing the observer
>to actually think about how the variable is to be used.

I wouldn't mind, except __attribute__(()) only works with gcc.

Bruce