From owner-cvs-all@FreeBSD.ORG Thu Jul 21 06:13:57 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 797331065679; Thu, 21 Jul 2011 06:13:57 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.vlsi.ee.noda.tus.ac.jp (sekine00.ee.noda.sut.ac.jp [133.31.107.40]) by mx1.freebsd.org (Postfix) with ESMTP id 339D98FC1E; Thu, 21 Jul 2011 06:13:56 +0000 (UTC) Received: from alph.allbsd.org (p3028-ipbf608funabasi.chiba.ocn.ne.jp [125.175.94.28]) (user=hrs mech=DIGEST-MD5 bits=128) by mail.vlsi.ee.noda.tus.ac.jp (8.14.4/8.14.4) with ESMTP id p6L6DYtv086317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Jul 2011 15:13:45 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id p6L6DXr8098315; Thu, 21 Jul 2011 15:13:34 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Thu, 21 Jul 2011 15:13:23 +0900 (JST) Message-Id: <20110721.151323.265642678034513451.hrs@allbsd.org> To: danfe@FreeBSD.org From: Hiroki Sato In-Reply-To: <20110721054015.GA72702@FreeBSD.org> References: <201107171118.p6HBIlc6096985@repoman.freebsd.org> <4E22E228.3020303@FreeBSD.org> <20110721054015.GA72702@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Thu_Jul_21_15_13_23_2011_939)--" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.5 (mail.vlsi.ee.noda.tus.ac.jp [133.31.107.40]); Thu, 21 Jul 2011 15:13:45 +0900 (JST) X-Spam-Status: No, score=2.8 required=14.0 tests=BAYES_50, CONTENT_TYPE_PRESENT, RCVD_IN_RP_RNBL, SPF_SOFTFAIL, X_MAILER_PRESENT autolearn=no version=3.3.1 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.vlsi.ee.noda.tus.ac.jp Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, mandree@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/ghostscript9 Makefile ports/print/ghostscript9/files patch-base-gdevl256.c patch-base-gdevvglb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 06:13:57 -0000 ----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Alexey Dokuchaev wrote in <20110721054015.GA72702@FreeBSD.org>: da> On Sun, Jul 17, 2011 at 03:22:48PM +0200, Matthias Andree wrote: da> > Am 17.07.2011 13:18, schrieb Hiroki Sato: da> > > hrs 2011-07-17 11:18:47 UTC da> > > da> > > Modified files: da> > > print/ghostscript9 Makefile da> > > Added files: da> > > print/ghostscript9/files patch-base-gdevl256.c da> > > patch-base-gdevvglb.c da> > > Log: da> > > Fix a build failure when vaglib and/or lvga256 is specified. da> > da> > It is very unfortunate that the PORTREVISION was bumped, and wasteful. da> > This was not necessary, let me explain: da> > da> > - if the build fails given specific (apparently non-default) options, da> > there is no prior port/package where files change da> > da> > - we bump PORTREVISION only if installed files or dependencies change. da> da> Even for deps/plist changes, it is not always necessary to bump revision. da> If, for example, port behavior is changed so it installs few extra files, da> PORTREVISION can be left intact, as long as previous version of the port has da> correct plist. On contrast, if pkg-plist was updated to include files that da> were installed but didn't have plist entry before, PORTREVISION should be da> bumped so users can get "fixed" package. da> da> In general, I totally agree with Matthias on this issue: please give enough da> thinking before bumping PORTREVISION. Sorry, I mistakenly thought one of the options was enabled by default for some reason. -- Hiroki ----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk4nw4QACgkQTyzT2CeTzy0ECgCePNpe5hCBHuPhKTILFNjcBwHY MXQAn2RW29vZZFccniMU399gBqzHQQLX =Xl3H -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)----