From owner-svn-src-head@freebsd.org  Thu Jan 26 03:50:51 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89549CC2FDA;
 Thu, 26 Jan 2017 03:50:51 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au
 [211.29.132.42])
 by mx1.freebsd.org (Postfix) with ESMTP id 4B120199C;
 Thu, 26 Jan 2017 03:50:50 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au
 [122.106.153.191])
 by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 6D25C3C389A;
 Thu, 26 Jan 2017 14:50:48 +1100 (AEDT)
Date: Thu, 26 Jan 2017 14:50:47 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Cy Schubert <cy@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r312780 - head/contrib/ipfilter/tools
In-Reply-To: <201701252059.v0PKxNsJ006302@repo.freebsd.org>
Message-ID: <20170126144726.U1265@besplex.bde.org>
References: <201701252059.v0PKxNsJ006302@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=H7qr+6Qi c=1 sm=1 tr=0
 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17
 a=kj9zAlcOel0A:10 a=uwsuDJgEXNybzttD0q4A:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2017 03:50:51 -0000

On Wed, 25 Jan 2017, Cy Schubert wrote:

> Log:
>  Remove extraneous blank line.
>
>  MFC after:	2 weeks
>  X-MFC with:	r312777
>
> Modified:
>  head/contrib/ipfilter/tools/ipf.c
>
> Modified: head/contrib/ipfilter/tools/ipf.c
> ==============================================================================
> --- head/contrib/ipfilter/tools/ipf.c	Wed Jan 25 20:59:06 2017	(r312779)
> +++ head/contrib/ipfilter/tools/ipf.c	Wed Jan 25 20:59:23 2017	(r312780)
> @@ -409,7 +409,6 @@ static void flushfilter(arg, filter)
> 		closedevice();
> 		return;
> 	}
> -
> 	else if (strchr(arg, 'i') || strchr(arg, 'I'))
> 		fl = FR_INQUE;
> 	else if (strchr(arg, 'o') || strchr(arg, 'O'))

Now it has 1 extra instead of 2 extra.

Most code in ipfilter, and all in the old version of this file, uses the
normal KNF style of cuddling elses.

Bruce