From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 25 21:20:07 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DF1EF16A4CE; Wed, 25 Aug 2004 21:20:07 +0000 (GMT)
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 98AE343D70; Wed, 25 Aug 2004 21:20:07 +0000 (GMT)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1])
	by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i7PLLnM3012909;
	Wed, 25 Aug 2004 14:21:49 -0700
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i7PLLnEJ012908;
	Wed, 25 Aug 2004 14:21:49 -0700
Date: Wed, 25 Aug 2004 14:21:49 -0700
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Tilman Linneweh <arved@freebsd.org>
Message-ID: <20040825212149.GA9405@odin.ac.hmc.edu>
References: <200408252059.i7PKx1fV014645@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP"
Content-Disposition: inline
In-Reply-To: <200408252059.i7PKx1fV014645@freefall.freebsd.org>
User-Agent: Mutt/1.4.1i
X-Virus-Scanned: by amavisd-new
X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu
cc: freebsd-bugs@freebsd.org
cc: rwatson@freebsd.org
Subject: Re: kern/33201: net/net_osdep.c:if_name is broken
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2004 21:20:08 -0000


--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 25, 2004 at 08:59:01PM +0000, Tilman Linneweh wrote:
> Synopsis: net/net_osdep.c:if_name is broken
>=20
> State-Changed-From-To: open->feedback
> State-Changed-By: arved
> State-Changed-When: Wed Aug 25 20:56:22 GMT 2004
> State-Changed-Why:=20
> It looks like this was resolved with the if_xname commit.
> Can this PR be closed?

Unless we care about fixing it in stable, we can close this.  if_name()
is correct other then a couple style bugs.

We might want to just nuke net_osdep.c and replace if_name() with:

#define	if_name(ifp)	((ifp)->if_xname)

This was over a year ago in NetBSD.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBLQLsXY6L6fI4GtQRAjZaAKDGLo1+78wuHYHL1Gu3xvSVDMqIeQCfUq9A
RejPauD+j1Dr5su9I1M0yq0=
=tlSF
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--