From owner-svn-src-head@FreeBSD.ORG Thu Apr 25 08:59:02 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D1C0DDB5 for ; Thu, 25 Apr 2013 08:59:01 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by mx1.freebsd.org (Postfix) with ESMTP id E1E5D16B1 for ; Thu, 25 Apr 2013 08:59:00 +0000 (UTC) Received: by mail-lb0-f178.google.com with SMTP id w10so2540627lbi.37 for ; Thu, 25 Apr 2013 01:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:openpgp:content-type :content-transfer-encoding:x-gm-message-state; bh=sMaARMMwqZ4LOCOXy85m54polADApK1bDzOBAtXC0AU=; b=Buqi5tXpbbaJ54ezy+GY0ZxNMxKoQ2E2IpPXfjBwzTuFR7Z2CsOx4O7s8Wjrs7g2pU +AKX3liHpfwLFDlqnubFdy8OW49dfeUlLNioHUy3UiC2nBb80njUqhsrrGJ9PO6SXcus davba40bNNQ2yuOFQvGj/8YyVOL4BFI5ItlgBPqW6dSwaqqQInydl3f1gQVhprYgmg1K UnWJ0F3sVaKoZcA4ev0Ryb/Riw3f0IZFot3Yi8mWSM7bUZD782azG2oK8K2XIW0DR1fZ Oxx0ebgGbIYxBCiFE6EKIgBO2HHnquRCBwjIiTWaqNVIKaXmuMvQjKVYHfvqH4fgnvUw cJhg== X-Received: by 10.112.133.72 with SMTP id pa8mr19718022lbb.114.1366880333894; Thu, 25 Apr 2013 01:58:53 -0700 (PDT) Received: from [192.168.1.2] ([89.169.163.3]) by mx.google.com with ESMTPSA id jl5sm2525053lbc.17.2013.04.25.01.58.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Apr 2013 01:58:53 -0700 (PDT) Message-ID: <5178F047.8080104@freebsd.org> Date: Thu, 25 Apr 2013 12:58:47 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Ronald Klop Subject: Re: svn commit: r249849 - in head/sys/dev: hptmv mpt References: <201304241900.r3OJ0jHL083318@svn.freebsd.org> In-Reply-To: OpenPGP: id=964474DD Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQnnsudJh7+QMPHE19W5i7Sf0KXHk2iFau61b4AfSO3XAy0HO21lStSSFK/61EQvsen3N2rT Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Alexander Motin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 08:59:03 -0000 On 25.04.2013 12:26, Ronald Klop wrote: > Hi, > > Maybe I need more coffee, but I don't see a difference between the if > and the else statements in the hptmv file. shutdown_kproc vs. kproc_shutdown > > Regards, > Ronald. > > On Wed, 24 Apr 2013 21:00:45 +0200, Alexander Motin > wrote: > >> Author: mav >> Date: Wed Apr 24 19:00:45 2013 >> New Revision: 249849 >> URL: http://svnweb.freebsd.org/changeset/base/249849 >> >> Log: >> Move hptmv and mpt drivers shutdown a bit later to the >> SHUTDOWN_PRI_LAST >> stage of shutdown_post_sync. That should allow CAM to do final >> cache flush >> at the SHUTDOWN_PRI_DEFAULT without using polling magic. >> MFC after: 3 days >> >> Modified: >> head/sys/dev/hptmv/entry.c >> head/sys/dev/mpt/mpt_pci.c >> >> Modified: head/sys/dev/hptmv/entry.c >> ============================================================================== >> >> --- head/sys/dev/hptmv/entry.c Wed Apr 24 18:30:32 2013 (r249848) >> +++ head/sys/dev/hptmv/entry.c Wed Apr 24 19:00:45 2013 (r249849) >> @@ -2605,9 +2605,11 @@ launch_worker_thread(void) >> * hpt_worker_thread needs to be suspended after shutdown sync, >> when fs sync finished. >> */ >> #if (__FreeBSD_version < 500043) >> - EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc, >> hptdaemonproc, SHUTDOWN_PRI_FIRST); >> + EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc, >> hptdaemonproc, >> + SHUTDOWN_PRI_LAST); >> #else >> - EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown, >> hptdaemonproc, SHUTDOWN_PRI_FIRST); >> + EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown, >> hptdaemonproc, >> + SHUTDOWN_PRI_LAST); >> #endif >> } >> /* >> >> Modified: head/sys/dev/mpt/mpt_pci.c >> ============================================================================== >> >> --- head/sys/dev/mpt/mpt_pci.c Wed Apr 24 18:30:32 2013 (r249848) >> +++ head/sys/dev/mpt/mpt_pci.c Wed Apr 24 19:00:45 2013 (r249849) >> @@ -563,7 +563,7 @@ mpt_pci_attach(device_t dev) >> } >> mpt->eh = EVENTHANDLER_REGISTER(shutdown_post_sync, mpt_pci_shutdown, >> - dev, SHUTDOWN_PRI_DEFAULT); >> + dev, SHUTDOWN_PRI_LAST); >> if (mpt->eh == NULL) { >> mpt_prt(mpt, "shutdown event registration failed\n"); >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- bitcoin:13fGiNutKNHcVSsgtGQ7bQ5kgUKgEQHn7N