From owner-freebsd-net@FreeBSD.ORG Wed Oct 6 01:09:14 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F8E3106566B for ; Wed, 6 Oct 2010 01:09:14 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from out-0.mx.aerioconnect.net (out-0-21.mx.aerioconnect.net [216.240.47.81]) by mx1.freebsd.org (Postfix) with ESMTP id 11F758FC15 for ; Wed, 6 Oct 2010 01:09:13 +0000 (UTC) Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160]) by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id o9619DIc013103; Tue, 5 Oct 2010 18:09:13 -0700 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137]) by idiom.com (Postfix) with ESMTP id A792A2D6015; Tue, 5 Oct 2010 18:09:12 -0700 (PDT) Message-ID: <4CABCC67.9070907@freebsd.org> Date: Tue, 05 Oct 2010 18:09:59 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Paul B Mahol References: <4CAB9212.4010203@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51 Cc: freebsd-net@freebsd.org Subject: Re: ndis: fix ugly code X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2010 01:09:14 -0000 On 10/5/10 5:27 PM, Paul B Mahol wrote: > On 10/5/10, Julian Elischer wrote: >> On 10/5/10 1:19 PM, Paul B Mahol wrote: >>> Hi, >>> >>> If clang did not complain, I would probbaly never spot it. >>> >>> Patch attached. >> personally I think you could use kproc_kthread_add so that a single >> NDIS process had three threads. > Patch attached. Now we have single "ndis" kernel process with own threads. I don't know how ndis works. Is it possible that each ndis driver would have it's own process? or would each instance? I don't even know if it's possible to run two different ndis drivers in the same kernel. if that was the case we'd want to have a different name for each one so you can tell them, but I just don't know enough about it.