From owner-cvs-sys Tue Nov 25 00:58:26 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id AAA27167 for cvs-sys-outgoing; Tue, 25 Nov 1997 00:58:26 -0800 (PST) (envelope-from owner-cvs-sys) Received: from gvr.gvr.org (root@gvr.gvr.org [194.151.74.97]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id AAA27159; Tue, 25 Nov 1997 00:58:18 -0800 (PST) (envelope-from guido@gvr.org) Received: (from guido@localhost) by gvr.gvr.org (8.8.6/8.8.5) id JAA09463; Tue, 25 Nov 1997 09:58:15 +0100 (MET) From: Guido van Rooij Message-Id: <199711250858.JAA09463@gvr.gvr.org> Subject: Re: cvs commit: src/sys/ufs/ufs ufs_bmap.c In-Reply-To: <199711241633.IAA21767@freefall.freebsd.org> from Bruce Evans at "Nov 24, 97 08:33:05 am" To: bde@freebsd.org (Bruce Evans) Date: Tue, 25 Nov 1997 09:58:15 +0100 (MET) Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: > bde 1997/11/24 08:33:04 PST > > Modified files: > sys/ufs/ufs ufs_bmap.c > Log: > Fixed overflow in ufs_getblns(). For ufs on systems with 32-bit ints, > triple indirect blocks only worked for block sizes of 4K, since > MNINDIR(ump)**3 overflows for larger block sizes (e.g., > (8192/4)**3 = 2**33 > INT_MAX). This fix is not the obvious one of > changing some types to 64 bits. It rearranges the code to avoid some > unnecessary 64-bit calculations. > Will you put this in 2.2? -Guido