From nobody Mon Dec 1 14:04:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dKlyZ3DDhz6JbKY for ; Mon, 01 Dec 2025 14:04:38 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dKlyZ09mzz47hx for ; Mon, 01 Dec 2025 14:04:38 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-477770019e4so34896345e9.3 for ; Mon, 01 Dec 2025 06:04:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764597876; x=1765202676; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FX671AXRveIQyNO1+CF4dypugnwDT0bqCYAYd+wUHxU=; b=jbqaT65BIGJeaHTUTy/UFLpJb/vXxDvT/d7zOpyb86xxLMR0cO78oPW1ZwacGnPoYA 6SgXSLQNM0tNd3eHKF401oNSzCtewb+D6OH5uLl11t0jN+zECtB12irJexQhyV9LpJ4m 3FwWJusUnBkxSuXl+YWGYgMX7fIIN6ZZ9Vi/3IlYJhh82JaGsdKF8Xjwq67315TeTGJ9 AdL81T6ytVyl+eTOUfqHhm36L2ViX0nn41EOzVnoDCQghCytRng5zc2LUuzCf/9ecJTm ZmdQZ8hJsO0iTUphoThYC/wfGXjrROvb6eDWJbRM5dXohQhFyROvUwgePIjbA5HDPUXR qFZQ== X-Forwarded-Encrypted: i=1; AJvYcCVPupGWSOTslJtS/41dpa/o2tofaQFbfkSVmDqnpwkN5nlQnEDpkBh6y176lSkCgNLv2Zmt83HG33Uv51izvxFPT2YNkA==@freebsd.org X-Gm-Message-State: AOJu0Yz7IJuduDTL9D193podrlWNNi9TGT0h9P3JYkFr0zykV7CEBMO5 pilKGZuA8DlSKtaiDQMgnl5nsZtKdUn0fEdpHO5LusHyfZA/4HSXqXC1W1GS+U+1ESg= X-Gm-Gg: ASbGncuG+eI/bWr9QD6F+cKt5W1qfeAGwyKrQZiQ8xTIAOlVu5zFApB8g5MXKbA9JOF TD9qOCoIVyJvETVK9D3IqmbjuBgXIyHf8vZwI5IBfOI0V4E/VDpCGheZaRwCN1JeAnr5Ddopf0m lMtf++Un9aoxgTok888d3m0XhnIsLaZOd+DihOmy7QyEx3ASlwVIT4hgeFBu/85F6vrxsQ/TyEp jRP9nbx/dUdNwxWh/mVRalewwOhqs8okuuTXzEx+38NboMhFa6s5rS9k7RIuAfclOl3UAOeuwVh evYvBN3oYMkqCpWoPjO1zZrgu4dwzZ6rZn/mdwhmPOEsIV+ik1gwpbuJ1Vk5cer2K7DsWNyKczE 9BLnItt3RCm4w58PNAoQ7Gxp0jQ7VKXffZuWR4JqWkMWD6J7+CS/lhWz2OPLQmSyL4e0yWDOero pmZqCOOvMus9ptoWCWPeCg7V4cjH9J/74uzY6nSqVVHLVl5LcYBRiF95ud0kf3WSU= X-Google-Smtp-Source: AGHT+IFM4cd3E1TjQmIJZRpXLxeFiWIw2iYAe4cIU1Wh+oQ6wktNl75OxtvysEZ7P1VQyfVd/Qg5IA== X-Received: by 2002:a05:600c:3b11:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-47904aceef6mr226888175e9.5.1764597874984; Mon, 01 Dec 2025 06:04:34 -0800 (PST) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca4078csm25926499f8f.29.2025.12.01.06.04.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Dec 2025 06:04:34 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.200.81.1.6\)) Subject: Re: git: 2fb8cbc6ef1b - main - libc/tests: add stdbit test framework and unit tests From: Jessica Clarke In-Reply-To: <3E139664-C0CE-4BB9-9225-66D7D44D644E@FreeBSD.org> Date: Mon, 1 Dec 2025 14:04:22 +0000 Cc: Robert Clausecker , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6903AA87-20BC-4060-A199-4100FC7CD8EB@freebsd.org> References: <692c9966.26e27.70621b5b@gitrepo.freebsd.org> <3E139664-C0CE-4BB9-9225-66D7D44D644E@FreeBSD.org> To: Kristof Provost X-Mailer: Apple Mail (2.3864.200.81.1.6) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dKlyZ09mzz47hx On 1 Dec 2025, at 13:56, Kristof Provost wrote: >=20 > On 30 Nov 2025, at 20:22, Robert Clausecker wrote: > The branch main has been updated by fuz: > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D2fb8cbc6ef1b3cc6cd60e5db07f83056= 23f9b044 > commit 2fb8cbc6ef1b3cc6cd60e5db07f8305623f9b044 > Author: Robert Clausecker fuz@FreeBSD.org > AuthorDate: 2025-11-18 17:33:12 +0000 > Commit: Robert Clausecker fuz@FreeBSD.org > CommitDate: 2025-11-30 19:21:52 +0000 > libc/tests: add stdbit test framework and unit tests >=20 > This adds unit tests for all 70 functions in . >=20 > I'm sorry for the test framework, but it makes it so I don't > have to write 70 unit tests by hand. >=20 > Reviewed by: adrian, des > Approved by: markj (mentor) > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D53660 >=20 > I=E2=80=99m having issues running the tests now. > I get this kyua error doing kyua list in /usr/tests/lib: > kyua: E: Load of 'Kyuafile' failed: Failed to load Lua file = 'Kyuafile': Kyuafile:48: Load of 'libc/Kyuafile' failed: Failed to load = Lua file 'libc/Kyuafile': libc/Kyuafile:19: Load of = 'libc/stdbit/Kyuafile' failed: File 'libc/stdbit/Kyuafile' not found. >=20 > That=E2=80=99s presumably because there=E2=80=99s no Kyuafile (or = indeed anything at all) in /usr/tests/lib/libc/stdbit. > It=E2=80=99s not immediately obvious to me what went wrong to cause = that, but I=E2=80=99m relatively confident it=E2=80=99s related to this = commit. > Best regards, > Kristof Because TESTSDIR is /usr/tests/lib/libc/tests/stdbit thanks to the location of libc=E2=80=99s tests in the src tree. That=E2=80=99s meant = to be overridden for every subdirectory, whether by including ../Makefile.netbsd-tests, in the case of all the NetBSD-imported ones, or by manually overriding it, such as in lib/libc/tests/iconv/Makefile. It would've been nice to test these tests prior to commit. Was that not done? Jessica