From owner-freebsd-net@FreeBSD.ORG  Sun Dec 14 03:35:17 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5799B16A4CF
	for <net@FreeBSD.org>; Sun, 14 Dec 2003 03:35:17 -0800 (PST)
Received: from relay.macomnet.ru (relay.macomnet.ru [195.128.64.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 877A543D35
	for <net@FreeBSD.org>; Sun, 14 Dec 2003 03:35:15 -0800 (PST)
	(envelope-from maxim@macomnet.ru)
Received: from news1.macomnet.ru (lumfglg7@news1.macomnet.ru [195.128.64.14])
	by relay.macomnet.ru (8.12.10/8.12.10) with ESMTP id hBEBZDkQ27343624;
	Sun, 14 Dec 2003 14:35:13 +0300 (MSK)
Date: Sun, 14 Dec 2003 14:35:13 +0300 (MSK)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Nate Grey <NateBSD@yahoo.it>
In-Reply-To: <200312141223.01385.NateBSD@yahoo.it>
Message-ID: <20031214143434.J94122@news1.macomnet.ru>
References: <200312131149.44582.NateBSD@yahoo.it>
	<20031213214424.E42015@news1.macomnet.ru>
	<200312141223.01385.NateBSD@yahoo.it>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: net@FreeBSD.org
Subject: Re: Fwd: 5.2-RC + ipfw
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2003 11:35:17 -0000

On Sun, 14 Dec 2003, 12:23-0000, Nate Grey wrote:

> On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
> > Please try an enclosed patch or put a whitespace right after the '('
> > before '\'.
> >
> > Index: ipfw2.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> > retrieving revision 1.42
> > diff -u -r1.42 ipfw2.c
> > --- ipfw2.c	31 Oct 2003 18:31:55 -0000	1.42
> > +++ ipfw2.c	13 Dec 2003 18:42:18 -0000
> > @@ -2901,15 +2901,14 @@
> >  		goto done;
> >
> >  #define OR_START(target)					\
> > -	if (ac && (*av[0] == '(' || *av[0] == '{')) {		\
> > +	if (ac && (						\
> > +	    !strncmp(*av, "(", strlen(*av)) ||			\
> > +	    !strncmp(*av, "{", strlen(*av)) )) {		\
> >  		if (open_par)					\
> >  			errx(EX_USAGE, "nested \"(\" not allowed\n"); \
> >  		prev = NULL;					\
> >  		open_par = 1;					\
> > -		if ( (av[0])[1] == '\0') {			\
> > -			ac--; av++;				\
> > -		} else						\
> > -			(*av)++;				\
> > +		ac--; av++;					\
> >  	}							\
> >  	target:							\
> >
> > %%%
>
> Problem solved just adding a whitespace. Should I apply the patch anyway?

Please do if you can.  Thanks.

-- 
Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org