From owner-freebsd-multimedia  Sun Jul 13 12:56:04 1997
Return-Path: <owner-multimedia>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id MAA05011
          for multimedia-outgoing; Sun, 13 Jul 1997 12:56:04 -0700 (PDT)
Received: from whqvax.picker.com (whqvax.picker.com [144.54.1.1])
          by hub.freebsd.org (8.8.5/8.8.5) with SMTP id MAA04989
          for <multimedia@freebsd.org>; Sun, 13 Jul 1997 12:55:59 -0700 (PDT)
Received: from ct.picker.com by whqvax.picker.com with SMTP;
          Sun, 13 Jul 1997 15:54:56 -0400 (EDT)
Received: from elmer.ct.picker.com ([144.54.57.34]) by ct.picker.com (4.1/SMI-4.1)
	id AA25601; Sun, 13 Jul 97 15:54:55 EDT
Received: by elmer.ct.picker.com (SMI-8.6/SMI-SVR4)
	id PAA05237; Sun, 13 Jul 1997 15:52:56 -0400
Message-Id: <19970713155256.41366@ct.picker.com>
Date: Sun, 13 Jul 1997 15:52:56 -0400
From: Randall Hopper <rhh@ct.picker.com>
To: Amancio Hasty <hasty@rah.star-gate.com>
Cc: multimedia@freebsd.org
Subject: guspnp9 feedback
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.76
Sender: owner-multimedia@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

     Had a few minutes to sit down and build the latest driver.  It appears
that you changed some protos in sound_calls.h and didn't flow them to all
the .c files.  attach looks like it now returns void rather than long and
doesn't take a mem_start arg anymore.  

     Not knowing what the intent was, I'm not sure I'd make the right fix.
Can you update the code and mail me the diffs.  Also, you might build a
sound driver with all the devices compiled in.  That should be a pretty
good build stress-test for the upcoming release.  (In particular, adding:

device awe0     at isa? port 0x620

will show the below problem.)

Thanks,

Randall


cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith  -nostdinc -I- -I. -I../.. -I/usr/include -DDEFAULT_CHNLSET=1 -DEXT2FS -DMSDOSFS -DCD9660 -DNFS -DFFS -DINET -DCOMPAT_43 -DKERNEL  ../../i386/isa/sound/awe_wave.c
../../i386/isa/sound/awe_wave.c:428: warning: initialization from incompatible pointer type
../../i386/isa/sound/awe_wave.c:450: conflicting types for `attach_awe_obsolete'
../../i386/isa/sound/sound_calls.h:136: previous declaration of `attach_awe_obsolete'
../../i386/isa/sound/awe_wave.c:514: warning: no previous prototype for `unload_awe'
*** Error code 1

Stop.