From owner-dev-commits-src-main@freebsd.org Wed Feb 17 20:45:16 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9CFD2532080; Wed, 17 Feb 2021 20:45:16 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgqbc27Zmz3MNs; Wed, 17 Feb 2021 20:45:15 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613594714; bh=Qg4lEJjxDesXoGA156htEplNvKPK4BJnHa7jCcAKTQs=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=bLE1FSd/FEKu8dKl60vAN9+WjZEXQNKYA7oDqDRt7cRpxggZhU/KmZe3kDVYEqoi5 GXahHg+7GgtfSd5dWp0PTHV94PdORWqn8oLd2KJKVlqRSSCeEh75JiC0um+5SpOuk4 zyE36zy09ULA5JYznFHgYx89acbRhMpVQClhJybk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([77.13.209.169]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MpDNl-1leBLK3LMl-00qn4z; Wed, 17 Feb 2021 21:45:13 +0100 Date: Wed, 17 Feb 2021 21:45:05 +0100 From: "Hartmann, O." To: Mark Johnston Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8ba333e02eaa - main - libdtrace: Stop relying on lex compatibility Message-ID: <20210217214505.0d4b544e@hermann.fritz.box> In-Reply-To: <202102171602.11HG2FVf099522@gitrepo.freebsd.org> References: <202102171602.11HG2FVf099522@gitrepo.freebsd.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xVHYogKjgyXovADc1VoD_Ap"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Provags-ID: V03:K1:M7c2psTg4HBoxoZdt4QzITJ6xqdbeRJBPZvPh+XAhiTMwCRfLxn L8OPi8KNM6/201MacOiQRZN3IFEmknFlRt0sHn5z+5Xk4BkBPnTKKS1Hp8rZ4TkSPDpt/bs WH8PLTHmHDhf8q9CN8rfQn8Z8CaJHNkgvmA6huiz7AK7A6/e63UWcYxh5s9xg6TYTrBzTEz kDidMbgTlfOG/f/Q5Iv/g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nHnNPZyBuqA=:cp0qavC1shzuBvP2Jhx1gs t4e25jDmrkmb0VFwn/vh1tzayxWlldJG8BzOqiEPF+uxbo0Eax1SErVuCNRwg2JzFg/asscOO AhK7JF0xz1WSGD9hO0EltByn3U8mH+1eC84gyah/RbliC9CC1L+98Q0Q/OY+9dgW40zQDpeqY /w4p0GR313Z7SOLLShOjwBRsUd0a1UCAuNPKQ5jwQ89r0ibHgFHohPRB3tzp+2BaUP2Lj0l+6 ayZuFiKkQZiv+uZpuIgjzfRaJV4KZ5EZc0EYuMfY+H5At9D8VBSz/NlMASiJbDRon50sbBWu5 1EfBFVfYIfbKcIE18TDpuh2L0zJxquVUiRx0GEVBkwwLxUK7H5I/tV9CutPulOBBNtvaxJffA r/qZadq+kUbyRQNNPWoDDqHdB8LFCLo3JbI6OvvR2j/3FTb46kx2HNV/K+CsxtWCTT6UI9WHu 5kqo4XIm9ycqNDO5d3GTYEcRI7ZgSBIOAuCr+TY/b0moZIxrjJgNL9kTb2qWpbwFJRYq+w5tf 6Bptgc0jK48ZQ8l0VK9YUHm7uZ9ixd8Asp6aZfVtI7ROa67ebAmdsZVQ0vDxAypxL9Mmobl5g LzdElIVtm63sdEtQ4+CNQm9995r5c8cypWiMGoXb4b3pqoS4qbHGjprC/S9mXcW9TIE/lCCb6 58MgvHoRGen8Ci7RxjkCfZ1/kwhQ9eZlhVmbkzhSqnI/9A0oxaWdqHzOYnSPi0NPKuRDQBaAg jcou+tnrYprgqmcDFdBvqUvrwlolsoenBCL7sOaVV8od7+gHlp3/44BKRk+C/3hlL7/D36iL9 8IpL7hk3pGZv7SU5/0hQKBdcFseVUuv2lQoKkQ37fCpK1M0DHp46d0YYvOD3oejdef05H2cvm 5gKNW0842xrvgA8tAW7w== X-Rspamd-Queue-Id: 4Dgqbc27Zmz3MNs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 20:45:16 -0000 --Sig_/xVHYogKjgyXovADc1VoD_Ap Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 17 Feb 2021 16:02:15 GMT Mark Johnston wrote: > The branch main has been updated by markj: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D8ba333e02eaa59337a4e1d5534= d4e894344c8226 >=20 > commit 8ba333e02eaa59337a4e1d5534d4e894344c8226 > Author: Mark Johnston > AuthorDate: 2021-02-17 15:49:38 +0000 > Commit: Mark Johnston > CommitDate: 2021-02-17 15:57:19 +0000 >=20 > libdtrace: Stop relying on lex compatibility > =20 > It does not appear to be required, and as of commit 6b7e592c215f > ("lex: Do not let input() return 0 when end-of-file is reached") it > causes input to return 0 instead of EOF when end-of-input is reached. > =20 > PR: 253440 > MFC after: 3 days > Sponsored by: The FreeBSD Foundation > --- > cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h | 2 +- > cddl/lib/libdtrace/Makefile | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h index > f2c60a2b07d4..b3f69bb6329d 100644 --- > a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h +++ > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h @@ -717,7 +717,= 7 @@ extern > dt_pcb_t *yypcb; /* pointer to current parser control block */ extern > char yyintprefix; /* int token prefix for macros (+/-) */ extern char > yyintsuffix[4]; /* int token suffix ([uUlL]*) */ extern int yyintdecimal; > /* int token is decimal (1) or octal/hex (0) */ -extern char yytext[]; > /* lex input buffer */ +extern char *yytext; /* lex input buffer */ > extern int yylineno; /* lex line number */ > extern int yydebug; /* lex debugging */ > extern dt_node_t *yypragma; /* lex token list for control lines */ > diff --git a/cddl/lib/libdtrace/Makefile b/cddl/lib/libdtrace/Makefile > index efd73751e2c0..45ca1692cf48 100644 > --- a/cddl/lib/libdtrace/Makefile > +++ b/cddl/lib/libdtrace/Makefile > @@ -129,8 +129,6 @@ SRCS+=3D dis_tables.c > DSRCS+=3D regs_x86.d > .endif > =20 > -LFLAGS+=3D-l > - > YFLAGS+=3D-d > =20 > LIBADD=3D ctf elf proc pthread rtld_db > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebs= d.org" This commit breaks buildworld (also breask starting from scratch/clean /usr= /obj): [...] -MD -MF.depend.arc_os.pico -MTarc_os.pico -std=3Diso9899:1999 -Wno-format-= zero-length -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -Wno-uninit= ialized -Wno-pointer-sign -Wno-unknown-pragmas -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-sw= itch-enum -Wno-knr-promoted-parameter -Qunused-arguments -c /usr/src/sys/contrib/openzfs/module/os/linux/zfs/arc_os.c -o arc_os.pico --- all_subdir_cddl/lib/libdtrace --- --- dt_names.o --- --- dt_lex.o --- In fi= le included from /usr/src/cddl/contrib/opensolaris/lib/libdtrace/common/dt_lex.l:38: /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_impl.h:720:14: error: redeclaration of 'yytext' with a different type: 'char *' vs 'char [= 8192]' extern char *yytext; /* lex input buffer */ ^ dt_lex.c:1075:6: note: pr= evious definition is here char yytext[YYLMAX]; ^ 1 error generated. *** [dt_lex.o]= Error code 1 make[5]: stopped in /usr/src/cddl/lib/libdtrace --- all_subdir_cddl/lib/libzpool --- --Sig_/xVHYogKjgyXovADc1VoD_Ap Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCYC2AUgAKCRA4N1ZZPba5 R/vgAP42V9RDDJU336cu1MV3elRbnQRQxvKyk+DmfPVXCWNALQD9GnIDPvIko2yW p1DqKDGDs/qPpQPfU3zyvFMMmtenVgs= =bNBT -----END PGP SIGNATURE----- --Sig_/xVHYogKjgyXovADc1VoD_Ap--