From owner-p4-projects@FreeBSD.ORG Sun Aug 31 20:01:14 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 712D51065679; Sun, 31 Aug 2008 20:01:14 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34858106566B for ; Sun, 31 Aug 2008 20:01:14 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 20B298FC22 for ; Sun, 31 Aug 2008 20:01:14 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7VK1EHv098117 for ; Sun, 31 Aug 2008 20:01:14 GMT (envelope-from nwhitehorn@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7VK1E5B098115 for perforce@freebsd.org; Sun, 31 Aug 2008 20:01:14 GMT (envelope-from nwhitehorn@freebsd.org) Date: Sun, 31 Aug 2008 20:01:14 GMT Message-Id: <200808312001.m7VK1E5B098115@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to nwhitehorn@freebsd.org using -f From: Nathan Whitehorn To: Perforce Change Reviews Cc: Subject: PERFORCE change 148931 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 20:01:14 -0000 http://perforce.freebsd.org/chv.cgi?CH=148931 Change 148931 by nwhitehorn@nwhitehorn_trantor on 2008/08/31 20:00:22 Remove some poorly motivated code in pmap_kremove() that could cause panics and accomplished nothing. Affected files ... .. //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#3 edit Differences ... ==== //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#3 (text+ko) ==== @@ -1559,26 +1559,6 @@ void moea64_kremove(mmu_t mmu, vm_offset_t va) { - struct pvo_entry *pvo; - struct lpte *pt; - - PMAP_LOCK(kernel_pmap); - pvo = moea64_pvo_find_va(kernel_pmap, va & ~ADDR_POFF, NULL); - KASSERT(pvo != NULL, ("moea64_kextract: no addr found")); - - LOCK_TABLE(); - pt = moea64_pvo_to_pte(pvo, -1); - if (pt != NULL) { - moea64_pte_synch(pt, &pvo->pvo_pte.lpte); - if (((pvo->pvo_pte.lpte.pte_lo & (LPTE_I | LPTE_G)) == 0) - && (pvo->pvo_pte.lpte.pte_lo & LPTE_CHG)) { - __syncicache((void *)va, PAGE_SIZE); - } - } - UNLOCK_TABLE(); - - PMAP_UNLOCK(kernel_pmap); - moea64_remove(mmu, kernel_pmap, va, va + PAGE_SIZE); }