From owner-p4-projects@FreeBSD.ORG Sun Apr 1 21:21:50 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1A85516A409; Sun, 1 Apr 2007 21:21:50 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E02AC16A407 for ; Sun, 1 Apr 2007 21:21:49 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 5297613C459 for ; Sun, 1 Apr 2007 21:21:49 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 3971 invoked from network); 1 Apr 2007 20:22:00 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 1 Apr 2007 20:22:00 -0000 Message-ID: <46101C26.5030306@freebsd.org> Date: Sun, 01 Apr 2007 22:55:02 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Kip Macy References: <200704012020.l31KKr0O097740@repoman.freebsd.org> In-Reply-To: <200704012020.l31KKr0O097740@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews Subject: Re: PERFORCE change 117123 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2007 21:21:50 -0000 Kip Macy wrote: > http://perforce.freebsd.org/chv.cgi?CH=117123 > > Change 117123 by kmacy@kmacy_vt-x:opentoe_init on 2007/04/01 20:20:02 > > add entry busdma tag to each each queue to allow mappings to be created in parallel > track zone and type for rx freelist for simplifying later free > convert rx freelists over to only using clusters, allocating the mbuf right before the > call to get_packet Thanks for using it. This was the idea behind providing this interface. From a cache busting point of view attaching the mbuf after the cluster has been filled is very good. The Sandvine guys found that out a long time ago and it indeed makes a lot of sense. When allocating whole clusters the mbuf gets touched twice, once at allocation and once when the driver fills in the information from the RX ring. This way it only gets touched in the latter case and the former cache pollution is skipped over. > This change alleviates a good portion of the recent (last 2 weeks) 18% performance drop > in peak TCP throughput Can you attribute any specific change to the drop in performance? -- Andre