From nobody Tue Jul 8 12:54:49 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bc1Kb4ft2z60y2G; Tue, 08 Jul 2025 12:54:59 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bc1KZ4vm3z3Ql8; Tue, 08 Jul 2025 12:54:58 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6fad4e6d949so24863596d6.0; Tue, 08 Jul 2025 05:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751979292; x=1752584092; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=3GtIFfyFoq0fiOuBaPw2Qdeagt03q6Q55OZ0ziNeq7E=; b=PTZ0QWBqky5EuArIq1cYSfPkMBreZo7Wl7YlnRp9uXhO+fERvQa5IOFdI4gqRgO6Ry ol2337k4y3s8s/dIxKKGMx52mxKcxKi+r57mv5KxOyEDmXDLJ2A4LWRjIvHthQ2p59D4 Zcrs/JGeYMn4FSaLBsdt6OTtS5nPKQHEMboyKGfkt8lvnW/RCvG9j9fcMoS3PRQZJG86 wLN7rMOhSat936dhUwobEJw4kBalb9CdfgEjzjcKCvgsXEl4s77eX7i4zH5jqVmWOlOZ aLBW/C1B4yMUXne367cJ1mJch8WOx162lCbGdKkHSEYEBZ6faOv/1mB/BcEZr21KZ2Hy T7ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751979292; x=1752584092; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3GtIFfyFoq0fiOuBaPw2Qdeagt03q6Q55OZ0ziNeq7E=; b=dyR1QcFYhhvpU2H+YW82MjRmaAFjLRRcvgTXTMc7Akm+p+Nn+aCBwgMPZpZsfP3Aju fnTPgSAr537X55knmkJ+1YQiRbhhs/sihAyeaDpPKdRkcJH56c+ljnrpeuqt4eg2+Eqg Tq5P4XVNvPCkM9bqwzm11zObF37FAp/gp6978eE1SeBbhDD6OPgbGz6IzTljgVn2inoI xn2E838seRXNHhz5bm3Fa7g3DvBnns4ZabTk91cXJFzeNxTrrwaXwQKPiNUaSvE/TnDe 9HbDGARQr8GSkCoy19igZusNGmRurhj2NOiJqaRbOrtdFm9+ijZYjym7YTq5znSbRLlY Iy/Q== X-Forwarded-Encrypted: i=1; AJvYcCU6uZXeUWgZsC9tdThTVv4As3X5aNedwS7MV4VX8u71MfL1PbSlxP5+beAt+DZpfqNRxsER+ecuUrBFYPuqoYjzKO0E@freebsd.org, AJvYcCWirzTCQBMi2pFwjjCkmyzG1ejPvpegppFZncyOiz0aad4mwwTJmV7s9THE3fIDSKx4SjTa+W/OuxoQk19QTQLz+NCS8ng=@freebsd.org X-Gm-Message-State: AOJu0YxBHnPfhhgUIV6ZYUgrpN2QACP3jVW8vEfq/PVhyNXxZMw4n8lU 2YfBcvyS91Ioph2Ebs9J2802h+tUmrGwU4YVgH/jK7eIB9jbDdK2gT4z9F+J1zrm8yA= X-Gm-Gg: ASbGncvHRD5bJNTqqkvOdxRxcfl9v3xJ9OE36w2X+0Pzx4ZrtHaGURnCq5N5XUHvnz5 BDJLMKCWqKLYRUgUusqnyrLhheFdyzt838f5Pe5A5wFBnmg/dpTSfhUdkG717iwB55OBRn+2/xc fWFWUrwbia58C5rwmPSE/H1YRT+h/uvBCCZks1KhdIKgWj7ZbkSEdGfqLL1XZjtkooxfhfqK7bN 1wAG9J36PedLNTDd1on9NEPZtX21nOHzinVhUdVr2Eci3e30kPTWTbBxZ97SOgoNmLRK90eVi6z urbMcDe/v9X6c5ogVgduOszlgAD6LJK3m5MxBZr/Ohl0akbKp4di6dJavAvCBvxDl08ivEGgRVm H X-Google-Smtp-Source: AGHT+IE6arMyyLvyM1BBJHplldK45/nZnwjdQ6kBKNiNLFehJhBIDjGeFDu0QeS/HebzeWNSofBThA== X-Received: by 2002:a05:6214:5905:b0:6fb:1c3:f527 with SMTP id 6a1803df08f44-702c8ce6b29mr274765996d6.39.1751979292068; Tue, 08 Jul 2025 05:54:52 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5ac78sm74945396d6.91.2025.07.08.05.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 05:54:51 -0700 (PDT) Date: Tue, 8 Jul 2025 08:54:49 -0400 From: Mark Johnston To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 01a679715f68 - main - err(3): print extended error if available Message-ID: References: <202507071928.567JSk8Y012639@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202507071928.567JSk8Y012639@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4bc1KZ4vm3z3Ql8 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Mon, Jul 07, 2025 at 07:28:46PM +0000, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=01a679715f68d5e32efecafc1f158eecec3f781b > > commit 01a679715f68d5e32efecafc1f158eecec3f781b > Author: Konstantin Belousov > AuthorDate: 2025-06-16 21:26:22 +0000 > Commit: Konstantin Belousov > CommitDate: 2025-07-07 18:44:22 +0000 > > err(3): print extended error if available > > Reviewed by: asomers, brooks > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D51141 This seems to cause extended errors to be printed unconditionally: root@freebsd:~ # truncate -r foo bar truncate: foo: No such file or directory (extended error No error) A number of tests fail due to this. Moreover, it doesn't seem useful to print a non-existent extended error. Can the extended error be suppressed in the "no error" case?