From owner-svn-src-head@freebsd.org Tue Dec 17 04:47:33 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20CDC1DB97C for ; Tue, 17 Dec 2019 04:47:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cQc42zf5z3KPs for ; Tue, 17 Dec 2019 04:47:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id c16so3505979qko.6 for ; Mon, 16 Dec 2019 20:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m7mWsPvAmx0ETpv8HLmw7B+yESp7TI9t38AKzV53q7A=; b=iZHIpG1pQUshE2GCfD0FCR8K3ztZufrg03ilbuohh/+c8lyL0QDaT/Gcmusvb8YImD e8o0GoeLEilS04SlAa9/1eM9tyztpI+D5zJBh9mKuzF17S5tQNAtiSms5VghjFSxRPB7 nOdjez59WECyDgu4PDxIiV73t8YK+phSTiX+qhrhqpwubo/N50ruL1rNChF7LH4/aoNf n24CpAk0UQhZ49Jg9yHUowz6+kkiYfAFKUjlK6l4vloFWzDuwtgGqi0L/GzFFlFWQKde TEhq8feUisWdy7teqvg8XfODns0X2gL3JtFOm92KOddMZQ9yiNpFxWyRIpsWzmm5Eina fL4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7mWsPvAmx0ETpv8HLmw7B+yESp7TI9t38AKzV53q7A=; b=BfcyS2wtlpe9RNxfTj5oxsYIeZwLrv4bvcnX/GUtojbZ0gwkyZN7maG7eDHBbhN7xt SK8qrOC1bwjiY/eofDVW49pSnBDtqv12y0/jf4XP0eOWaibZsCyFxI7t9LcuY/dFbCR+ kHX0gCEFfTOcwFKi/T5n/SH2o/QOQTQrNECNHLsXeAcFIV/md2Tc4Vl3OptD5sYHe5G4 1s2k0ZAU17vASpFLG6FCUOsfm5cumd8U/fOCoCwtR1iG0Phy2gyDamd1g7aBWHPw+T8f IeA+p8wJQcl5sMFqhO6A+gl9xJK8O58XODMdwHrV2CXqbEclRMUkL+QxoSdxfZ9w6xPk VP/w== X-Gm-Message-State: APjAAAVnYT7u0qFUDGGlke57FBwLMDu/+MZT0ittAYS58EWhgfQnsub2 ndp8If/IChiGLgICrGgo5Hkgah0o7WIYZjF2sheLwQ== X-Google-Smtp-Source: APXvYqyrrxriu7Ep/ulvUq6DpVGJLQkJJKBe7Szl71mkQ8llRFINAdE2iFOZCuXudKnJn3AORn1G0r+J7m6QLoJkpCs= X-Received: by 2002:a05:620a:94f:: with SMTP id w15mr3050422qkw.380.1576558050809; Mon, 16 Dec 2019 20:47:30 -0800 (PST) MIME-Version: 1.0 References: <201912162355.xBGNtUq6078840@repo.freebsd.org> <201912170442.xBH4gUOg063777@slippy.cwsent.com> In-Reply-To: <201912170442.xBH4gUOg063777@slippy.cwsent.com> From: Warner Losh Date: Mon, 16 Dec 2019 21:47:18 -0700 Message-ID: Subject: Re: svn commit: r355828 - head/sys/sys To: Cy Schubert Cc: "Pedro F. Giffuni" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 47cQc42zf5z3KPs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=iZHIpG1p; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::731) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.68 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.68)[ip: (-9.25), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 04:47:33 -0000 On Mon, Dec 16, 2019, 9:42 PM Cy Schubert wrote: > In message <201912162355.xBGNtUq6078840@repo.freebsd.org>, "Pedro F. > Giffuni" w > rites: > > Author: pfg > > Date: Mon Dec 16 23:55:30 2019 > > New Revision: 355828 > > URL: https://svnweb.freebsd.org/changeset/base/355828 > > > > Log: > > Double the size of ARG_MAX on LP64 platforms. > > > > As modern software keeps growing in size, we get requests to update the > > value of ARG_MAX in order to link the resulting object files. Other OSs > > have much higher values but Increasiong ARG_MAX has a multiplied > effect on > > KVA, so just bumping this value is dangerous in some archs like ARM32 > that > > can exhaust KVA rather easily. > > > > While it would be better to have a unique value for all archs, other > OSs > > (Illumos in partidular) can have different ARG_MAX limits depending on > the > > platform, For now we want to be really conservative so we are avoidng > > the change on ILP32 and in the alternative case we only double it > since tha > > t > > seems to work well enough for recent Code Aster. > > > > I was planning to bump the _FreeBSD_version but it was bumped recently > > (r355798) so we can reuse the 1300068 value for this change. > > This doesn't seem right. Each bump should be for a distinct change and > documented as such. > In the past we've said to piggy back versions when less than a day has passed since the last bump. The hard part on this is that follow through on actually documenting both has been lax. Warner Also, it's not like we're saving any build time anyway. sys/syslimits.h > will cause a substantial portion to be rebuilt anyway. > > > > > PR: 241710 > > MFC after: 5 days > > > > Modified: > > head/sys/sys/syslimits.h > > > > Modified: head/sys/sys/syslimits.h > > > ============================================================================= > > = > > --- head/sys/sys/syslimits.h Mon Dec 16 23:08:09 2019 (r355827) > > +++ head/sys/sys/syslimits.h Mon Dec 16 23:55:30 2019 (r355828) > > @@ -48,7 +48,11 @@ > > * Do not add any new variables here. (See the comment at the end of > > * the file for why.) > > */ > > -#define ARG_MAX 262144 /* max bytes for an exec > functi > > on */ > > +#ifndef __ILP32__ > > +#define ARG_MAX (2 * 256 * 1024) /* max bytes for an exec > functi > > on */ > > +#else > > +#define ARG_MAX (256 * 1024) /* max bytes for > KVA-starved ar > > chs */ > > +#endif > > #ifndef CHILD_MAX > > #define CHILD_MAX 40 /* max simultaneous > processes * > > / > > #endif > > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > >