From owner-freebsd-hackers  Wed Jul 11 19: 2: 6 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id 8893C37B403
	for <hackers@freebsd.org>; Wed, 11 Jul 2001 19:02:04 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP id 26A463E31
	for <hackers@freebsd.org>; Wed, 11 Jul 2001 19:02:02 -0700 (PDT)
To: hackers@freebsd.org
Subject: Trailing newline in panic() calls
Date: Wed, 11 Jul 2001 19:02:01 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010712020202.26A463E31@bazooka.unixfreak.org>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

Hi folks,

There are quite a few places in the kernel where panic(9) is called
with a trailing newline.  E.g.:

	panic("vm_page_free: freeing wired page\n");

That '\n' is redundant, because panic() will print that by itself.  Is
there any reason not to correct these calls?  panic() OpenBSD and
NetBSD also prints a newline for the user, so there are no portability
issues.

					Dima Dorfman
					dima@unixfreak.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message