Date: Sat, 15 Aug 1998 17:41:41 -0700 (PDT) From: Bruce Evans <bde@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/sys/i386/i386 mp_machdep.c pmap.c Message-ID: <199808160041.RAA24097@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
bde 1998/08/15 17:41:40 PDT
Modified files:
sys/i386/i386 mp_machdep.c pmap.c
Log:
pmap.c:
Cast pointers to (vm_offset_t) instead of to (u_long) (as before) or to
(uintptr_t)(void *) (as would be more correct). Don't cast vm_offset_t's
to (u_long) just to do arithmetic on them.
mp_machdep.c:
Cast pointers to (uintptr_t) instead of to (u_long). Don't forget
to cast pointers to (void *) first or to recover from integral
possible integral promotions, although this is too much work for
machine-dependent code.
vm code generally avoids warnings for pointer vs long size mismatches
by using vm_offset_t to represent pointers; pmap.c often uses plain
`unsigned int' instead of vm_offset_t and didn't use u_long elsewhere,
but this style was messed up by code apparently imported from mp_machdep.c.
Revision Changes Path
1.77 +4 -4 src/sys/i386/i386/mp_machdep.c
1.206 +8 -7 src/sys/i386/i386/pmap.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808160041.RAA24097>