From owner-svn-src-head@freebsd.org Thu Oct 22 19:35:45 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2891C428C3C; Thu, 22 Oct 2020 19:35:45 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CHHdr5NWnz4QDW; Thu, 22 Oct 2020 19:35:44 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 4CHHdj1wRVz3n0y; Thu, 22 Oct 2020 19:35:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id EgzR6tyJptif; Thu, 22 Oct 2020 19:35:36 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:1201:b119:c381:545a:fb32]) by mail.daemonic.se (Postfix) with ESMTPSA id 4CHHdh1khKz3mQt; Thu, 22 Oct 2020 19:35:36 +0000 (UTC) Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf To: Kyle Evans , Warner Losh Cc: "Alexander V. Chernikov" , Hans Petter Selasky , Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <43251602934532@mail.yandex.ru> <59021602950992@mail.yandex.ru> From: Niclas Zeising Message-ID: Date: Thu, 22 Oct 2020 21:35:35 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CHHdr5NWnz4QDW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:36236, ipnet:2607:f740:d::/48, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 19:35:45 -0000 On 2020-10-22 15:22, Kyle Evans wrote: > On Sat, Oct 17, 2020 at 11:40 AM Warner Losh wrote: >> >> >> >> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov wrote: >>> >>> 17.10.2020, 14:07, "Hans Petter Selasky" : >>> >>> On 2020-10-17 14:34, Alexander V. Chernikov wrote: >>> >>> 17.10.2020, 12:32, "Hans Petter Selasky" : >>> >>> On 2020-10-17 13:27, Alexander V. Chernikov wrote: >>> >>> 02.10.2020, 19:26, "Emmanuel Vadot" >> >: >>> >>> Author: manu >>> Date: Fri Oct 2 18:26:41 2020 >>> New Revision: 366372 >>> URL: https://svnweb.freebsd.org/changeset/base/366372 >>> >>> Log: >>> linuxkpi: Add backlight support >>> >>> Add backlight function to linuxkpi. >>> Graphics drivers expose the backlight of the panel directly so >>> allow them >>> to use the backlight subsystem so >>> user can use backlight(8) to configure them. >>> >>> Reviewed by: hselasky >>> Relnotes: yes >>> Differential Revision: The FreeBSD Foundation >>> >>> Added: >>> head/sys/compat/linuxkpi/common/include/linux/backlight.h >>> (contents, >>> props changed) >>> Modified: >>> head/sys/compat/linuxkpi/common/include/linux/device.h >>> head/sys/compat/linuxkpi/common/src/linux_kmod.c >>> head/sys/compat/linuxkpi/common/src/linux_pci.c >>> head/sys/conf/kmod.mk >>> >>> It breaks the build for me with >>> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: >>> fatal error: 'backlight_if.h' file not found >>> >>> >>> How do you build? Doesn't break over here. >>> >>> GENERIC + COMPAT_LINUXKPI. >>> >>> >>> >>> Try adding: >>> >>> options backlight >>> >>> To the kernel config. >>> >>> Yep, thank you! >>> Maybe it's worth considering adding static assert with the message describing this dependency? >> >> >> Yes. It likely is worth doing something to highlight this issue. >> >> Warner >> > > I think we just need to slap the two core backlight files with an ` | > compat_linux` so that they simply get pulled in if you specify > COMPAT_LINUX. config(8) handles this terribly, configng must have a > better provides/requires/implies/whatever functionality so we can > specify that compat_linux implies backlight and not do crud like this > where it becomes more complicated to see what any given option really > entails. > > Thanks, COMPAT_LINUX can't be right. Isn't that the linuxolator? Regards -- Niclas Zeising